This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Log when an insecure Https -> Http redirect is blocked #27077
Merged
rmkerr
merged 7 commits into
dotnet:master
from
rmkerr:HttpClient_InsecureRedirect_Logging
Feb 20, 2018
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9cf03be
Add logging for insecure redirects on WinHttp.
f4aa723
Improve WinHttp logging, add CurlHandler logging.
0442d33
Add SocketsHttpHandler logging, add source and dest URIs to logging.
c1a2edd
WinHttpHandler builds against Net Standard, which does not include ne…
4f4306d
Ensure that String.Format is not called when logging is disabled.
f6cc6d2
Check if tracing is enabled in WInHttp before testing the status code…
4c47965
Remove interpolation
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unlike the other two, this one is fine, as it's guarded by the NetEventSource.IsEnabled check. The costs will only be incurred when tracing is enabled.