This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
File IO #32668
Merged
Merged
File IO #32668
Changes from 112 commits
Commits
Show all changes
121 commits
Select commit
Hold shift + click to select a range
b448fa1
Baseline commit, get things back to state in original PR
paul1956 beb4fd7
Remove #Const that was left over from old PR
paul1956 b37d54c
Merge branch 'master' of https://github.com/paul1956/corefx
paul1956 5c31e56
Update to lastest master, addd FileIO, MsgBox on Windows (throw on ot…
paul1956 578dc10
Minor cleanup to not require VB 15.5, fix Msgbox Ref, remove unnessar…
paul1956 d64039c
Resolve Conflict
paul1956 0595054
FIx some Unix configuration issues
paul1956 0e81bf6
Add manual Tests on Windows for MsgBox and automatic test for Unix
paul1956 a56a933
Cleanup comments and Doc Comments in TextFieldParser and add addition…
paul1956 8e986aa
Cleanup formatting, dead comments...
paul1956 e3fc96f
Add missing license comments and more comment cleanup.
paul1956 0e94766
Minor changes to make code more readable
paul1956 e6fd317
Modify to conform to Reference Source format and ordering
paul1956 752e804
Move Constants out of Globals where they don't belong. Restore 3 Reso…
paul1956 f2f9681
More code cleanup
paul1956 603530c
Merge branch 'master' into FileIO1
paul1956 01a9637
Add tests framework for TextFieldParser
paul1956 6015255
Merge branch 'FileIO1' of https://github.com/paul1956/corefx into Fil…
paul1956 d3e594f
Resolve conflicts
paul1956 f718dc0
All tests for SpecialDirectories and TextFieldParser, add resources f…
paul1956 7b58cbf
FIx FixedFormatTest
paul1956 da2aef2
FIx spelling of Unix Error string
paul1956 a949726
Ignore errors in tests on OS's that don't support SpecialDirectory. A…
paul1956 ea4ceb9
Fix DriveInfo tests
paul1956 cb9cee1
Add Option Strict to tests to capture subtle bugs.
paul1956 ee06784
Merge FileSystem.Portable back into FileSystem, remove stale comments…
paul1956 189a6e5
Update logic for creating Application Specific Paths and remove inval…
paul1956 2ee8fbf
Add missing license text and fix location of Option's. Add needed com…
paul1956 9a9f253
Fix and add test for SpecialDirectories.MyDocument on Nano
paul1956 fe22219
Added commented out Debugging code to Dummy so others will find it. F…
paul1956 eba899c
Still trying to fix SpecialDirectories on Windows.10.Amd64.ClientRS4.…
paul1956 68b8326
Stilll trying to ignore failing test on Windows.10.Amd64.ClientRS4.Op…
paul1956 74d25d2
All files have been restore to original function order as best as po…
paul1956 39278ca
Move OS independ function from Windows specific file to Common file.
paul1956 828f1ca
Improve tests on Nano
paul1956 9cea56d
Temporary fix to debug failing test (Do not review)
paul1956 04db821
Fix issue where ApplicatioData folder was not created.
paul1956 cd73966
[Don't review] Still debugging failing special directory tests.
paul1956 3040712
Still working on fixes to OS specific SpecialDirectories
paul1956 4023740
Add additional Diagnostics to SpecialDirectoriesTests
paul1956 594815d
Remove trailing / or \
paul1956 3a0abc1
Correct comment
paul1956 89b00e1
Remove / and \ from end of SpecialFolder.ApplicationData.
paul1956 930dfda
Still fine tuning Special Directory Tests.
paul1956 d27ed91
More attempts to fix CurrentUserApplicationData on one system
paul1956 9ef5f97
Address PR comments, restructure code to follow Reference Source, fix…
paul1956 ccfb5a8
Add missing license file and remove Windows code from Unix builds
paul1956 8c184db
Fix Unix builds
paul1956 d48ccf1
HostProtection does not exist
paul1956 105fd4d
Fix string.length = 0 to = ""
paul1956 26cfda8
Address all PR Feedback. A lot of moving stuff around to match Refere…
paul1956 2404f30
Fix issue where MakeValidFileName always returned "" and implemented …
paul1956 efd3a1d
Address PR feedback, fix implementation CreateValidFullPath
paul1956 6c845f1
Remove debugging code causing tests to fail
paul1956 e7a50b3
Address more PR Feedback
paul1956 50cb064
Add code to catch all the ways special folders to fail for DEBUG ONLY…
paul1956 5df803a
Remove unused code and updates SpecialDirectoryTests for new logic
paul1956 757fe58
Fine tuning GetCompanyProductVersionList
paul1956 a9bcf47
More fine tuning of SpecialDirectories for Unix
paul1956 1373b0c
More fixes to SpecialDirectories
paul1956 f1d3329
Change tests for UnsupportedPlatforms to look for correct error.
paul1956 f26ab27
Change error handling and CurrentUserApplicationDataFolderTest to han…
paul1956 2ca5a3b
Update tests to account for PlatformNotSupportedException
paul1956 35580bf
Remove debug code, change error message to provide inner exception. F…
paul1956 95e143b
Moved MsgBox to Tests.VB, reverted all FileIO functions to match Refe…
paul1956 e30829f
Remove MessageBox Unix tests
paul1956 108aa0e
Remove MsgBox Code from project file vs comment out per PR Feedback.
paul1956 4ca5470
HostProtection not available, so it is commented out until I can get …
paul1956 4493b4a
Make FileIO.Windows not compile on Unix
paul1956 8c7de9e
Address PR feedback
paul1956 e58c1b4
Normalize line-feeds, remove some double CRLF's
paul1956 94cd1ce
Move MoveFileExFlags Enum to FileIO.Vb since it is needed for both Un…
paul1956 0e5843d
Add NativeMethods.Unix to handle MoveFileEx stub which will never be …
paul1956 3f013cf
Remove IsAttached used for debugging
paul1956 c611c64
Add a stub for ThrowWinIOError for Unix
paul1956 ccd1017
Move Windows Specific function to .Windows file, create stuff for Non…
paul1956 52d88b4
Fix Unix stub
paul1956 8e92eb8
Change test from = Unix to != Windows
paul1956 54824de
Address PR feedback, delete excluded files
paul1956 e8e2ec6
Move more MsgBox artifacts to VB.Test.Interactive.Windows
paul1956 229a41e
Move more MsgBox artifacts to VB/Tests/Interactive.Windows.vb
paul1956 d28a04a
Merge branch 'FileIO1' of https://github.com/paul1956/corefx into Fil…
paul1956 0cdc142
Move MoveFileExFlags to NativeTypes and remove some extra blank lines.
paul1956 a600af4
Remove Sealed Modifier from Ref file
paul1956 0bde4e7
Remove Sealed Modifier from Special Directories to match Reference
paul1956 924c563
Address PR Feedback
paul1956 ad61781
Restore file to Commit 7cad8486 before I made any changes
paul1956 3edf5e4
Remove Interaction from Public API, the fact that is not public is a …
paul1956 e0a985c
Revert back to commit 74126cad by Omar Tawfik
paul1956 24f6c5b
Remove Interaction.Windows.VB from VB Test Project.
paul1956 1f9d5bb
All long path test
paul1956 ded2b2c
Fix logic error in FileSystemWindows.vb and add helper routine to con…
paul1956 29c8fef
Minor cleanup, don't review
paul1956 96fa94a
FIx failures on non-windows platforms
paul1956 25a8f06
Add support for testing long paths,
paul1956 9f51441
Test on Unix to make sure exception in thrown, fix crash in LongDirec…
paul1956 ffe2889
Remove comment from Ref file, address PR feedback in SpecialDirectoie…
paul1956 47b46df
Fix LongDirectoryPathTest on systems that don't support long paths
paul1956 09b77d2
Fix off by 1, directory name length must be LESS than 248. Add some d…
paul1956 46bcb67
Fix another off by 1
paul1956 54511c8
Simplify LongPathTests
paul1956 1bfb5ba
Remove PathFeatures, create simple check for LongPathSupport, remove …
paul1956 05d8860
Improve LongPath detection. Add tests for LongPathSupport, at least o…
paul1956 5dd7ea3
Address PR Feedback and continue to test LongDirectoryPaths. Lots of …
paul1956 a02679a
Fix logic and remove duplicate function
paul1956 80f7b14
Remove all LongDirectoryPath testing, if needed add to future PR
paul1956 af26d55
Add LongDirectoryPathTest back with improved logic, add back Shared t…
paul1956 fa13905
Test LongDirectoryPaths without creating multiple subdirectories auto…
paul1956 7eced6a
Correct length of directory name
paul1956 01649dc
Add additional checks for LongDirectoryPathTest to handle different e…
paul1956 29340a9
Add additional diagnostic to LongDirectoryPathTest, reduce duplicate …
paul1956 23406a3
Issue #3387 will prevent LongDirectPath from actually working on all …
paul1956 84953b2
Address all PR Feedback
paul1956 b3185fd
Fix helper function WriteFIle, remove left over code, fix off by 1
paul1956 dbb5762
Fix test for Wildcard Match
paul1956 2bb4445
Fix more off by 1 and some comments
paul1956 85c8ddd
Add comment to reflect source of MultiFormatTest
paul1956 0e9977e
Merge branch 'master' into FileIO1
cston 5cdc4d1
Update Configuration.props
cston eef3cb7
Update proj files
cston 7946e18
Exclude Windows implementation from package
cston File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,6 +44,11 @@ public sealed partial class Collection : System.Collections.ICollection, System. | |
public void Remove(int Index) { } | ||
public void Remove(string Key) { } | ||
} | ||
public enum CompareMethod | ||
{ | ||
Binary = 0, | ||
Text = 1, | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please move There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is where it was before I started in Commit 2dde65 |
||
[System.AttributeUsageAttribute((System.AttributeTargets)(4), Inherited=false, AllowMultiple=false)] | ||
public sealed partial class ComClassAttribute : System.Attribute | ||
{ | ||
|
@@ -56,17 +61,11 @@ public sealed partial class ComClassAttribute : System.Attribute | |
public string InterfaceID { get { throw null; } } | ||
public bool InterfaceShadows { get { throw null; } set { } } | ||
} | ||
public enum CompareMethod | ||
{ | ||
Binary = 0, | ||
Text = 1, | ||
} | ||
[Microsoft.VisualBasic.CompilerServices.StandardModuleAttribute] | ||
public sealed partial class Constants | ||
{ | ||
internal Constants() { } | ||
public const string vbBack = "\b"; | ||
public const Microsoft.VisualBasic.CompareMethod vbBinaryCompare = Microsoft.VisualBasic.CompareMethod.Binary; | ||
public const string vbCr = "\r"; | ||
public const string vbCrLf = "\r\n"; | ||
public const string vbFormFeed = "\f"; | ||
|
@@ -76,9 +75,11 @@ public sealed partial class Constants | |
public const string vbNullChar = "\0"; | ||
public const string vbNullString = null; | ||
public const string vbTab = "\t"; | ||
public const Microsoft.VisualBasic.CompareMethod vbTextCompare = Microsoft.VisualBasic.CompareMethod.Text; | ||
public const string vbVerticalTab = "\v"; | ||
public const CompareMethod vbBinaryCompare = CompareMethod.Binary; | ||
public const CompareMethod vbTextCompare = CompareMethod.Text; | ||
} | ||
|
||
public sealed partial class ControlChars | ||
{ | ||
public const char Back = '\b'; | ||
|
@@ -482,3 +483,159 @@ public partial class NetworkAvailableEventArgs : System.EventArgs | |
public bool IsNetworkAvailable { get { throw null; } } | ||
} | ||
} | ||
namespace Microsoft.VisualBasic.FileIO | ||
{ | ||
public enum DeleteDirectoryOption | ||
{ | ||
DeleteAllContents = 5, | ||
ThrowIfDirectoryNonEmpty = 4, | ||
} | ||
public enum FieldType | ||
{ | ||
Delimited = 0, | ||
FixedWidth = 1, | ||
} | ||
public partial class FileSystem | ||
{ | ||
public FileSystem() { } | ||
public static string CurrentDirectory { get { throw null; } set { } } | ||
public static System.Collections.ObjectModel.ReadOnlyCollection<System.IO.DriveInfo> Drives { get { throw null; } } | ||
public static string CombinePath(string baseDirectory, string relativePath) { throw null; } | ||
public static void CopyDirectory(string sourceDirectoryName, string destinationDirectoryName) { } | ||
public static void CopyDirectory(string sourceDirectoryName, string destinationDirectoryName, bool overwrite) { } | ||
public static void CopyDirectory(string sourceDirectoryName, string destinationDirectoryName, UIOption showUI) { } | ||
public static void CopyDirectory(string sourceDirectoryName, string destinationDirectoryName, UIOption showUI, UICancelOption onUserCancel) { } public static void CopyFile(string sourceFileName, string destinationFileName) { } | ||
public static void CopyFile(string sourceFileName, string destinationFileName, bool overwrite) { } | ||
public static void CopyFile(string sourceFileName, string destinationFileName, UIOption showUI) { } | ||
public static void CopyFile(string sourceFileName, string destinationFileName, UIOption showUI, UICancelOption onUserCancel) { } | ||
public static void CreateDirectory(string directory) { } | ||
public static void DeleteDirectory(string directory, DeleteDirectoryOption onDirectoryNotEmpty) { } | ||
public static void DeleteDirectory(string directory, UIOption showUI, RecycleOption recycle) { } | ||
public static void DeleteDirectory(string directory, UIOption showUI, RecycleOption recycle, UICancelOption onUserCancel) { } | ||
public static void DeleteFile(string file) { } | ||
public static void DeleteFile(string file, UIOption showUI, RecycleOption recycle) { } | ||
public static void DeleteFile(string file, UIOption showUI, RecycleOption recycle, UICancelOption onUserCancel) { } | ||
public static bool DirectoryExists(string directory) { throw null; } | ||
public static bool FileExists(string file) { throw null; } | ||
public static System.Collections.ObjectModel.ReadOnlyCollection<string> FindInFiles(string directory, string containsText, bool ignoreCase, Microsoft.VisualBasic.FileIO.SearchOption searchType) { throw null; } | ||
public static System.Collections.ObjectModel.ReadOnlyCollection<string> FindInFiles(string directory, string containsText, bool ignoreCase, Microsoft.VisualBasic.FileIO.SearchOption searchType, params string[] fileWildcards) { throw null; } | ||
public static System.Collections.ObjectModel.ReadOnlyCollection<string> GetDirectories(string directory) { throw null; } | ||
public static System.Collections.ObjectModel.ReadOnlyCollection<string> GetDirectories(string directory, SearchOption searchType, params string[] wildcards) { throw null; } | ||
public static System.IO.DirectoryInfo GetDirectoryInfo(string directory) { throw null; } | ||
public static System.IO.DriveInfo GetDriveInfo(string drive) { throw null; } | ||
public static System.IO.FileInfo GetFileInfo(string file) { throw null; } | ||
public static System.Collections.ObjectModel.ReadOnlyCollection<string> GetFiles(string directory) { throw null; } | ||
public static System.Collections.ObjectModel.ReadOnlyCollection<string> GetFiles(string directory, SearchOption searchType, params string[] wildcards) { throw null; } | ||
public static string GetName(string path) { throw null; } | ||
public static string GetParentPath(string path) { throw null; } | ||
public static string GetTempFileName() { throw null; } | ||
public static void MoveDirectory(string sourceDirectoryName, string destinationDirectoryName) { } | ||
public static void MoveDirectory(string sourceDirectoryName, string destinationDirectoryName, bool overwrite) { } | ||
public static void MoveDirectory(string sourceDirectoryName, string destinationDirectoryName, UIOption showUI) { } | ||
public static void MoveDirectory(string sourceDirectoryName, string destinationDirectoryName, UIOption showUI, UICancelOption onUserCancel) { } | ||
public static void MoveFile(string sourceFileName, string destinationFileName) { } | ||
public static void MoveFile(string sourceFileName, string destinationFileName, bool overwrite) { } | ||
public static void MoveFile(string sourceFileName, string destinationFileName, UIOption showUI) { } | ||
public static void MoveFile(string sourceFileName, string destinationFileName, UIOption showUI,UICancelOption onUserCancel) { } | ||
public static TextFieldParser OpenTextFieldParser(string file) { throw null; } | ||
public static TextFieldParser OpenTextFieldParser(string file, params int[] fieldWidths) { throw null; } | ||
public static TextFieldParser OpenTextFieldParser(string file, params string[] delimiters) { throw null; } | ||
public static System.IO.StreamReader OpenTextFileReader(string file) { throw null; } | ||
public static System.IO.StreamReader OpenTextFileReader(string file, System.Text.Encoding encoding) { throw null; } | ||
public static System.IO.StreamWriter OpenTextFileWriter(string file, bool append) { throw null; } | ||
public static System.IO.StreamWriter OpenTextFileWriter(string file, bool append, System.Text.Encoding encoding) { throw null; } | ||
public static byte[] ReadAllBytes(string file) { throw null; } | ||
public static string ReadAllText(string file) { throw null; } | ||
public static string ReadAllText(string file, System.Text.Encoding encoding) { throw null; } | ||
public static void RenameDirectory(string directory, string newName) { } | ||
public static void RenameFile(string file, string newName) { } | ||
public static void WriteAllBytes(string file, byte[] data, bool append) { } | ||
public static void WriteAllText(string file, string text, bool append) { } | ||
public static void WriteAllText(string file, string text, bool append, System.Text.Encoding encoding) { } | ||
} | ||
public partial class MalformedLineException : System.Exception | ||
{ | ||
public MalformedLineException() { } | ||
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Advanced)] | ||
protected MalformedLineException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { } | ||
public MalformedLineException(string message) { } | ||
public MalformedLineException(string message, System.Exception innerException) { } | ||
public MalformedLineException(string message, long lineNumber) { } | ||
public MalformedLineException(string message, long lineNumber, System.Exception innerException) { } | ||
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Always)] | ||
public long LineNumber { get { throw null; } set { } } | ||
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Advanced)] | ||
public override void GetObjectData(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { } | ||
public override string ToString() { throw null; } | ||
} | ||
public enum RecycleOption | ||
{ | ||
DeletePermanently = 2, | ||
SendToRecycleBin = 3, | ||
} | ||
public enum SearchOption | ||
{ | ||
SearchAllSubDirectories = 3, | ||
SearchTopLevelOnly = 2, | ||
} | ||
public partial class SpecialDirectories | ||
{ | ||
public SpecialDirectories() { } | ||
public static string AllUsersApplicationData { get { throw null; } } | ||
public static string CurrentUserApplicationData { get { throw null; } } | ||
public static string Desktop { get { throw null; } } | ||
public static string MyDocuments { get { throw null; } } | ||
public static string MyMusic { get { throw null; } } | ||
public static string MyPictures { get { throw null; } } | ||
public static string ProgramFiles { get { throw null; } } | ||
public static string Programs { get { throw null; } } | ||
public static string Temp { get { throw null; } } | ||
} | ||
public partial class TextFieldParser : System.IDisposable | ||
{ | ||
public TextFieldParser(System.IO.Stream stream) { } | ||
public TextFieldParser(System.IO.Stream stream, System.Text.Encoding defaultEncoding) { } | ||
public TextFieldParser(System.IO.Stream stream, System.Text.Encoding defaultEncoding, bool detectEncoding) { } | ||
public TextFieldParser(System.IO.Stream stream, System.Text.Encoding defaultEncoding, bool detectEncoding, bool leaveOpen) { } | ||
public TextFieldParser(System.IO.TextReader reader) { } | ||
public TextFieldParser(string path) { } | ||
public TextFieldParser(string path, System.Text.Encoding defaultEncoding) { } | ||
public TextFieldParser(string path, System.Text.Encoding defaultEncoding, bool detectEncoding) { } | ||
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Advanced)] | ||
public string[] CommentTokens { get { throw null; } set { } } | ||
public string[] Delimiters { get { throw null; } set { } } | ||
public bool EndOfData { get { throw null; } } | ||
public string ErrorLine { get { throw null; } } | ||
public long ErrorLineNumber { get { throw null; } } | ||
public int[] FieldWidths { get { throw null; } set { } } | ||
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Advanced)] | ||
public bool HasFieldsEnclosedInQuotes { get { throw null; } set { } } | ||
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Advanced)] | ||
public long LineNumber { get { throw null; } } | ||
public Microsoft.VisualBasic.FileIO.FieldType TextFieldType { get { throw null; } set { } } | ||
public bool TrimWhiteSpace { get { throw null; } set { } } | ||
public void Close() { } | ||
void Dispose() { } | ||
protected virtual void Dispose(bool disposing) { } | ||
~TextFieldParser() { } | ||
public string PeekChars(int numberOfChars) { throw null; } | ||
public string[] ReadFields() { throw null; } | ||
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Advanced)] | ||
public string ReadLine() { throw null; } | ||
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Advanced)] | ||
public string ReadToEnd() { throw null; } | ||
public void SetDelimiters(params string[] delimiters) { } | ||
public void SetFieldWidths(params int[] fieldWidths) { } | ||
void System.IDisposable.Dispose() { throw new System.NotImplementedException(); } | ||
} | ||
public enum UICancelOption | ||
{ | ||
DoNothing = 2, | ||
ThrowException = 3 | ||
} | ||
public enum UIOption | ||
{ | ||
OnlyErrorDialogs = 2, | ||
AllDialogs = 3 | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,8 @@ | |
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
<PropertyGroup> | ||
<BuildConfigurations> | ||
netstandard; | ||
netstandard-Unix; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We want to keep a RID-less implementation since this goes into a package. Can we rename this configuration from |
||
netstandard-Windows_NT; | ||
_netfx; | ||
</BuildConfigurations> | ||
</PropertyGroup> | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reference assemblies cannot differ by runtime. Runtime is never considered when resolving files that get passed to the compiler.