This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
SqlClient Allow specifying a UDT SqlParameter value as bytes #36678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[edit] with a little help from the corefx gitter it should be properly rebased now. |
Wraith2
force-pushed
the
sqlfeat-udtbytes
branch
from
c346344
to
21e1b5d
Compare
saurabh500
approved these changes
Apr 25, 2019
AfsanehR-zz
approved these changes
Apr 25, 2019
|
Tests passed. |
|
@David-Engel Any idea what is going on here? (see dotnet/efcore#16097) We were under the impression that this PR had been merged into |
|
@ajcvickers I have a list of a few dozen changes that were merged into System.Data.SqlClient over the past 6 months (since we snapped the code for Microsoft.Data.SqlClient). Only about a dozen made it into Microsoft.Data.SqlClient for the preview and this was not one of them. We've been working through the rest of them as time permits. I'll make sure this one makes it into the next preview. |
JRahnama
pushed a commit
to JRahnama/SqlClient
that referenced
this pull request
Sep 5, 2019
…alue as bytes Port change to both netcore and netfx. dotnet/corefx#36678 Adds special casing when writing UDT parameter values to the TDS stream so that if the value is byte[] or SqlBytes the value is sent to the server and not rejected as invalid. This allows users to handle serialization and deserialization logic without having to have SqlClient be aware of the types and without using inefficient text representations. Related work items: #8819
BradBarnich
added a commit
to BradBarnich/EntityFramework
that referenced
this pull request
Feb 16, 2021
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
SqlClient Allow specifying a UDT SqlParameter value as bytes Commit migrated from dotnet/corefx@aff33dc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/dotnet/corefx/issues/35470
Adds special casing when writing UDT parameter values to the TDS stream so that if the value is
byte[]orSqlBytesthe value is sent to the server and not rejected as invalid. This allows users to handle serialization and deserialization logic without having to have SqlClient be aware of the types and without using inefficient text representations.Two new tests are added to verify the behaviour. Functional and manual tests pass.
/cc area owners @afsanehr, @tarikulsabbir, @Gary-Zh , @David-Engel and requester @bricelam