This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Port Constants, Globals, DateAndTime #37376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@333fred, @jaredpar, please review. |
333fred
approved these changes
May 2, 2019
danmoseley
reviewed
May 2, 2019
| Namespace Microsoft.VisualBasic.CompilerServices | ||
|
|
||
| <System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)> _ | ||
| <SecurityCritical()> _ |
There was a problem hiding this comment.
SecurityCritical, SuppressUnmanagedCodeSecurityAttribute, ResourceExposure are all attributes that don't have function in .NET Core. #Resolved
danmoseley
approved these changes
May 2, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Port Constants, Globals, DateAndTime * PR feedback * Add DateString test * Remove using Commit migrated from dotnet/corefx@ecb4d64
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port
Microsoft.VisualBasic.DateAndTimeand the missing members ofMicrosoft.VisualBasic.{Constants,Globals}from https://github.com/Microsoft/referencesource/tree/master/Microsoft.VisualBasic/runtime/msvbalib.The changes from reference source were limited to comments and attributes only. The implementation was not changed.
Some tests added for
DateAndTime.