Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing .ConfigureAwait(false) in HttpConnectionPool #38610

Merged
merged 1 commit into from Jun 17, 2019

Conversation

@stephentoub
Copy link
Member

stephentoub commented Jun 17, 2019

No description provided.

@stephentoub stephentoub merged commit 3b2707b into master Jun 17, 2019
15 checks passed
15 checks passed
WIP Ready for review
Details
corefx-ci Build #20190617.30 succeeded
Details
corefx-ci (Linux RedHat6_x64_Release) Linux RedHat6_x64_Release succeeded
Details
corefx-ci (Linux arm64_Debug) Linux arm64_Debug succeeded
Details
corefx-ci (Linux arm_Debug) Linux arm_Debug succeeded
Details
corefx-ci (Linux musl_arm64_Debug) Linux musl_arm64_Debug succeeded
Details
corefx-ci (Linux musl_x64_Debug) Linux musl_x64_Debug succeeded
Details
corefx-ci (Linux x64_Debug) Linux x64_Debug succeeded
Details
corefx-ci (MacOS x64_Debug) MacOS x64_Debug succeeded
Details
corefx-ci (Packaging All Configurations x64_Debug) Packaging All Configurations x64_Debug succeeded
Details
corefx-ci (Windows NETFX_x86_Release) Windows NETFX_x86_Release succeeded
Details
corefx-ci (Windows UWP_CoreCLR_x64_Debug) Windows UWP_CoreCLR_x64_Debug succeeded
Details
corefx-ci (Windows x64_Debug) Windows x64_Debug succeeded
Details
corefx-ci (Windows x86_Release) Windows x86_Release succeeded
Details
license/cla All CLA requirements met.
@stephentoub stephentoub deleted the stephentoub-configureawait branch Jun 17, 2019
@yv989c

This comment has been minimized.

Copy link

yv989c commented Dec 25, 2019

So maybe this is the reason why the client library I wrote was deadlocking when used on a sync-over-async fashion (ASP.NET), and my last resort was to use Task.Run.

@es-repo

This comment has been minimized.

Copy link

es-repo commented Jan 11, 2020

@yv989c most likely yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.