[master] Update dependencies from 4 repositories #39557
[master] Update dependencies from 4 repositories #39557
Conversation
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
@safern, can you help here? This is failing to restore, with:
|
@agocke could you share the restore feed for the .ci package version we put in arcade? |
I will instead wait for: dotnet/arcade#3312 to go in to avoid adding a RestoreSource for a short period of time. Once that is merged and published, I'll update this PR. |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
@agocke it seems like the version of the compiler that we updated to is not tracking Debug.Assert in the data flow analysis and all the places where we added Debug.Assert(foo != null) are warning when trying to dereference foo afterwards. Is it the correct version of the compiler? Or what happened? |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
Nevermind, I know what's happening. Debug.Assert was special cased in the compiler, it seems like the specialization was removed, so the projects that are building against netstandard/netfx since those frameworks are not annotated, Debug.Assert doesn't have I think we should bring that specialization for Debug.Assert back to the compiler, can we do that? |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
@agocke, @jcouv, it looks like the compiler's special-casing of methods like Debug.Assert was just removed a few days ago in dotnet/roslyn#34916. Are we sure we want to do that? cc: @terrajobst |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
I think it is important to special case those methods or annotate them in netstandard as if people want to enable nullability in their .netstandard2.0/2.1 projects, it really helps to annotate and to avoid having to add a bunch of |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
We discussed keeping a special case for |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
I added: c937ff2 to disable nullable warns for netstandard and netfx, once we decide what to do for netstandard we can remove the nowarn for it. |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
0b42534
to
46e746c
Compare
|
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
4c721cf
to
f1120c3
Compare
@@ -8,7 +8,6 @@ | |||
<clear /> | |||
<add key="dotnet-core" value="https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json" /> | |||
<add key="dotnet-coreclr" value="https://dotnetfeed.blob.core.windows.net/dotnet-coreclr/index.json" /> | |||
<!-- TODO: Remove when an updated coverlet.console package is pushed to nuget.org. Issue: #39595 --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👿👿👿
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Investigating the failure, it is because we don't have a 5.0 targeting pack in the SDK yet and we're trying to test against a 5.0 RuntimeFrameworkVersion in the 3.0 package testing. The fix will be a bigger change that might involve a change in arcade. Already taking care of the fix. |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
cc: @wtgodbe FYI on what I had to do for package testing now that we rebranded to 5.0 |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
…90716.2 - NETStandard.Library - 2.2.0-prerelease.19366.2
2a92c01
to
345d0b1
Compare
…720.5 - runtime.native.System.IO.Ports - 5.0.0-alpha1.19370.5 - Microsoft.NETCore.Platforms - 5.0.0-alpha1.19370.5
…90720.2 - NETStandard.Library - 2.2.0-prerelease.19370.2
Closing in favor of: #39662 |
This pull request updates the following dependencies
From https://github.com/dotnet/standard
From https://github.com/dotnet/arcade
From https://github.com/dotnet/core-setup
From https://github.com/dotnet/corefx