Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

[master] Update dependencies from 4 repositories #39557

Closed

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 16, 2019

This pull request updates the following dependencies

From https://github.com/dotnet/standard

  • Build: 20190720.2
  • Date Produced: 7/20/2019 1:26 PM
  • Commit: 72b16fc9b77a004c6b9ca93f4856624d8bb0c864
  • Branch: refs/heads/master
  • Updates:
    • NETStandard.Library -> 2.2.0-prerelease.19370.2

From https://github.com/dotnet/arcade

  • Build: 20190719.2
  • Date Produced: 7/19/2019 5:55 PM
  • Commit: a190d4865fe3c86a168ec49c4fc61c90c96ae051
  • Branch: refs/heads/master
  • Updates:
    • Microsoft.DotNet.XUnitExtensions -> 2.4.1-beta.19369.2
    • Microsoft.DotNet.XUnitConsoleRunner -> 2.5.1-beta.19369.2
    • Microsoft.DotNet.VersionTools.Tasks -> 1.0.0-beta.19369.2
    • Microsoft.DotNet.ApiCompat -> 1.0.0-beta.19369.2
    • Microsoft.DotNet.Arcade.Sdk -> 1.0.0-beta.19369.2
    • Microsoft.DotNet.Build.Tasks.Configuration -> 1.0.0-beta.19369.2
    • Microsoft.DotNet.Build.Tasks.Feed -> 2.2.0-beta.19369.2
    • Microsoft.DotNet.Build.Tasks.Packaging -> 1.0.0-beta.19369.2
    • Microsoft.DotNet.CodeAnalysis -> 1.0.0-beta.19369.2
    • Microsoft.DotNet.CoreFxTesting -> 1.0.0-beta.19369.2
    • Microsoft.DotNet.GenAPI -> 1.0.0-beta.19369.2
    • Microsoft.DotNet.Helix.Sdk -> 2.0.0-beta.19369.2
    • Microsoft.DotNet.RemoteExecutor -> 1.0.0-beta.19369.2
    • Microsoft.DotNet.GenFacades -> 1.0.0-beta.19369.2

From https://github.com/dotnet/core-setup

  • Build: 20190719.08
  • Date Produced: 7/19/2019 8:26 PM
  • Commit: 7d70bbe81b4b86d491e30f957551441464c85375
  • Branch: refs/heads/master
  • Updates:
    • Microsoft.NETCore.App -> 5.0.0-alpha1.27919.8
    • Microsoft.NETCore.DotNetHostPolicy -> 5.0.0-alpha1.27919.8
    • Microsoft.NETCore.DotNetHost -> 5.0.0-alpha1.27919.8

From https://github.com/dotnet/corefx

  • Build: 20190720.5
  • Date Produced: 7/21/2019 4:24 AM
  • Commit: 9bb93a6
  • Branch: refs/heads/master
  • Updates:
    • runtime.native.System.IO.Ports -> 5.0.0-alpha1.19370.5
    • Microsoft.NETCore.Platforms -> 5.0.0-alpha1.19370.5

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jul 16, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: corefx-ci, corefx-ci (Linux arm64_Debug), corefx-ci (Linux musl_arm64_Debug), corefx-ci (MacOS x64_Debug), corefx-ci (Linux arm_Debug), corefx-ci (Windows UWP_CoreCLR_x64_Debug), corefx-ci (Linux musl_x64_Debug), corefx-ci (Windows NETFX_x86_Release), corefx-ci (Windows x86_Release), corefx-ci (Windows x64_Debug), corefx-ci (Linux x64_Debug), corefx-ci (Linux RedHat6_x64_Release), corefx-ci (Packaging All Configurations x64_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@dotnet-maestro dotnet-maestro bot changed the title [master] Update dependencies from dotnet/standard [master] Update dependencies from dotnet/standard dotnet/arcade Jul 17, 2019
@dotnet-maestro dotnet-maestro bot changed the title [master] Update dependencies from dotnet/standard dotnet/arcade [master] Update dependencies from dotnet/standard dotnet/arcade dotnet/core-setup Jul 17, 2019
@dotnet-maestro dotnet-maestro bot changed the title [master] Update dependencies from dotnet/standard dotnet/arcade dotnet/core-setup [master] Update dependencies from 4 repositories Jul 17, 2019
@stephentoub stephentoub reopened this Jul 17, 2019
@stephentoub
Copy link
Member

@safern, can you help here? This is failing to restore, with:

D:\a\1\s\.dotnet\sdk\3.0.100-preview7-012630\MSBuild.dll /nologo -maxcpucount /m -verbosity:m /v:minimal /bl:D:\a\1\s\artifacts\log\Debug\ToolsetRestore.binlog /clp:Summary /clp:ErrorsOnly;NoSummary /nr:False /p:ContinuousIntegrationBuild=True /p:TreatWarningsAsErrors=true /p:__ToolsetLocationOutputFile=D:\a\1\s\artifacts\toolset\1.0.0-beta.19366.4.txt /t:__WriteToolsetLocation /warnaserror D:\a\1\s\artifacts\toolset\restore.proj
D:\a\1\s\.dotnet\sdk\3.0.100-preview7-012630\MSBuild.dll /nologo -maxcpucount /m -verbosity:m /v:minimal /bl:D:\a\1\s\artifacts\log\Debug\Build.binlog /clp:Summary /logger:D:\a\1\s\.packages\microsoft.dotnet.arcade.sdk\1.0.0-beta.19366.4\tools\netcoreapp2.1\Microsoft.DotNet.Arcade.Sdk.dll /nr:False /p:ContinuousIntegrationBuild=True /p:TreatWarningsAsErrors=true /p:Configuration=Debug /p:RepoRoot=D:\a\1\s /p:Restore=True /p:DeployDeps=False /p:Build=False /p:Rebuild=False /p:Deploy=False /p:Test=False /p:Pack=False /p:IntegrationTest=False /p:PerformanceTest=False /p:Sign=False /p:Publish=False /p:ConfigurationGroup=Debug /p:ArchGroup=x64 /p:TargetGroup=netcoreapp /p:ArchiveTests=Tests /p:RuntimeOS=win10 /warnaserror D:\a\1\s\.packages\microsoft.dotnet.arcade.sdk\1.0.0-beta.19366.4\tools\Build.proj
D:\a\1\s\.packages\microsoft.dotnet.arcade.sdk\1.0.0-beta.19366.4\tools\Tools.proj : error NU1603: Tools depends on Microsoft.Net.Compilers.Toolset (>= 3.3.0-ci.final) but Microsoft.Net.Compilers.Toolset 3.3.0-ci.final was not found. An approximate best match of Microsoft.Net.Compilers.Toolset 9.9.0-beta3-19304-14 was resolved.
##[error].packages\microsoft.dotnet.arcade.sdk\1.0.0-beta.19366.4\tools\Tools.proj(0,0): error NU1603: Tools depends on Microsoft.Net.Compilers.Toolset (>= 3.3.0-ci.final) but Microsoft.Net.Compilers.Toolset 3.3.0-ci.final was not found. An approximate best match of Microsoft.Net.Compilers.Toolset 9.9.0-beta3-19304-14 was resolved.
  Restore failed in 9.93 sec for D:\a\1\s\.packages\microsoft.dotnet.arcade.sdk\1.0.0-beta.19366.4\tools\Tools.proj.

@safern
Copy link
Member

safern commented Jul 17, 2019

@agocke could you share the restore feed for the .ci package version we put in arcade?

@safern
Copy link
Member

safern commented Jul 17, 2019

I will instead wait for: dotnet/arcade#3312 to go in to avoid adding a RestoreSource for a short period of time. Once that is merged and published, I'll update this PR.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jul 17, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: corefx-ci (Windows NETFX_x86_Release)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@safern
Copy link
Member

safern commented Jul 18, 2019

@agocke it seems like the version of the compiler that we updated to is not tracking Debug.Assert in the data flow analysis and all the places where we added Debug.Assert(foo != null) are warning when trying to dereference foo afterwards. Is it the correct version of the compiler? Or what happened?

@dotnet-maestro
Copy link
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: corefx-ci (Windows NETFX_x86_Release)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@safern
Copy link
Member

safern commented Jul 18, 2019

Nevermind, I know what's happening. Debug.Assert was special cased in the compiler, it seems like the specialization was removed, so the projects that are building against netstandard/netfx since those frameworks are not annotated, Debug.Assert doesn't have DoesNotReturnWhen attributes, therefore it is not affecting nullability.

I think we should bring that specialization for Debug.Assert back to the compiler, can we do that?

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jul 18, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies No un-ignored checks.
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@stephentoub
Copy link
Member

stephentoub commented Jul 18, 2019

Debug.Assert was special cased in the compiler, it seems like the specialization was removed, so the projects that are building against netstandard/netfx since those frameworks are not annotated, Debug.Assert doesn't have DoesNotReturnWhen attributes, therefore it is not affecting nullability. I think we should bring that specialization for Debug.Assert back to the compiler, can we do that?

@agocke, @jcouv, it looks like the compiler's special-casing of methods like Debug.Assert was just removed a few days ago in dotnet/roslyn#34916. Are we sure we want to do that?

cc: @terrajobst

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jul 18, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies No un-ignored checks.
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@safern
Copy link
Member

safern commented Jul 18, 2019

I think it is important to special case those methods or annotate them in netstandard as if people want to enable nullability in their .netstandard2.0/2.1 projects, it really helps to annotate and to avoid having to add a bunch of ! -- we could also annotate those methods only in ns2.0/2.1, but we would need to also add the needed attributes to it.

@dotnet-maestro
Copy link
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies No un-ignored checks.
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@safern safern closed this Jul 18, 2019
@safern safern reopened this Jul 18, 2019
@jcouv
Copy link
Member

jcouv commented Jul 18, 2019

it looks like the compiler's special-casing of methods like Debug.Assert was just removed a few days ago in dotnet/roslyn#34916. Are we sure we want to do that?

We discussed keeping a special case for Debug.Assert, but decided to remove it. That was before the recent netstandard2.1 discussion getting re-opened. It seems like a slippery slope though, why stop at that method?

Tagging @cston @gafter

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jul 18, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: corefx-ci, corefx-ci (Windows UWP_CoreCLR_x64_Debug), corefx-ci (Windows NETFX_x86_Release), corefx-ci (MacOS x64_Debug), corefx-ci (Windows x86_Release), corefx-ci (Windows x64_Debug), corefx-ci (Linux musl_x64_Debug), corefx-ci (Linux x64_Debug), corefx-ci (Linux RedHat6_x64_Release), corefx-ci (Packaging All Configurations x64_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@jcouv
Copy link
Member

jcouv commented Jul 18, 2019

From discussion with @agocke @cston, it seems a better solution to annotate Debug.Assert and string.IsNullOrEmpty/Whitespace in netstandard since we'll be adding the attribute definitions in netstandard anyways.
Is there a reason this wouldn't work?

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jul 18, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: corefx-ci, corefx-ci (Linux arm64_Debug), corefx-ci (Linux musl_arm64_Debug), corefx-ci (Linux arm_Debug), corefx-ci (MacOS x64_Debug), corefx-ci (Linux musl_x64_Debug), corefx-ci (Linux x64_Debug), corefx-ci (Windows UWP_CoreCLR_x64_Debug), corefx-ci (Linux RedHat6_x64_Release), corefx-ci (Windows NETFX_x86_Release), corefx-ci (Windows x86_Release), corefx-ci (Packaging All Configurations x64_Debug), corefx-ci (Windows x64_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@safern
Copy link
Member

safern commented Jul 18, 2019

I added: c937ff2 to disable nullable warns for netstandard and netfx, once we decide what to do for netstandard we can remove the nowarn for it.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jul 18, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: corefx-ci, corefx-ci (Packaging All Configurations x64_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@safern safern force-pushed the darc-master-d2b9090e-1b05-4420-81c4-cb6624abb1da branch from 0b42534 to 46e746c Compare July 18, 2019 22:57
@ViktorHofer
Copy link
Member

@ericstj @safern

Testing Microsoft.Win32.SystemEvents TFM=netcoreapp2.1
C:\dotnetbuild\work\63fe311e-06a7-4b84-a142-50b502dedee5\Payload\tools\sdk\3.0.100-preview7-012630\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.TargetingPackResolution.targets(161,5): error MSB4018: The "ResolveTargetingPackAssets" task failed unexpectedly. [C:\dotnetbuild\work\63fe311e-06a7-4b84-a142-50b502dedee5\Work\89d40cf2-66b1-44ee-83e4-cc4823501d07\Unzip\netcoreapp3.0\project.csproj]
C:\dotnetbuild\work\63fe311e-06a7-4b84-a142-50b502dedee5\Payload\tools\sdk\3.0.100-preview7-012630\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.TargetingPackResolution.targets(161,5): error MSB4018: System.InvalidOperationException: Sequence contains no matching element [C:\dotnetbuild\work\63fe311e-06a7-4b84-a142-50b502dedee5\Work\89d40cf2-66b1-44ee-83e4-cc4823501d07\Unzip\netcoreapp3.0\project.csproj]
C:\dotnetbuild\work\63fe311e-06a7-4b84-a142-50b502dedee5\Payload\tools\sdk\3.0.100-preview7-012630\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.TargetingPackResolution.targets(161,5): error MSB4018:    at System.Linq.ThrowHelper.ThrowNoMatchException() [C:\dotnetbuild\work\63fe311e-06a7-4b84-a142-50b502dedee5\Work\89d40cf2-66b1-44ee-83e4-cc4823501d07\Unzip\netcoreapp3.0\project.csproj]
C:\dotnetbuild\work\63fe311e-06a7-4b84-a142-50b502dedee5\Payload\tools\sdk\3.0.100-preview7-012630\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.TargetingPackResolution.targets(161,5): error MSB4018:    at System.Linq.Enumerable.First[TSource](IEnumerable`1 source, Func`2 predicate) [C:\dotnetbuild\work\63fe311e-06a7-4b84-a142-50b502dedee5\Work\89d40cf2-66b1-44ee-83e4-cc4823501d07\Unzip\netcoreapp3.0\project.csproj]
C:\dotnetbuild\work\63fe311e-06a7-4b84-a142-50b502dedee5\Payload\tools\sdk\3.0.100-preview7-012630\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.TargetingPackResolution.targets(161,5): error MSB4018:    at Microsoft.NET.Build.Tasks.ResolveTargetingPackAssets.ExecuteCore() in /_/src/Tasks/Microsoft.NET.Build.Tasks/ResolveTargetingPackAssets.cs:line 96 [C:\dotnetbuild\work\63fe311e-06a7-4b84-a142-50b502dedee5\Work\89d40cf2-66b1-44ee-83e4-cc4823501d07\Unzip\netcoreapp3.0\project.csproj]
C:\dotnetbuild\work\63fe311e-06a7-4b84-a142-50b502dedee5\Payload\tools\sdk\3.0.100-preview7-012630\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.TargetingPackResolution.targets(161,5): error MSB4018:    at Microsoft.NET.Build.Tasks.TaskBase.Execute() in /_/src/Tasks/Common/TaskBase.cs:line 47 [C:\dotnetbuild\work\63fe311e-06a7-4b84-a142-50b502dedee5\Work\89d40cf2-66b1-44ee-83e4-cc4823501d07\Unzip\netcoreapp3.0\project.csproj]
C:\dotnetbuild\work\63fe311e-06a7-4b84-a142-50b502dedee5\Payload\tools\sdk\3.0.100-preview7-012630\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.TargetingPackResolution.targets(161,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [C:\dotnetbuild\work\63fe311e-06a7-4b84-a142-50b502dedee5\Work\89d40cf2-66b1-44ee-83e4-cc4823501d07\Unzip\netcoreapp3.0\project.csproj]
C:\dotnetbuild\work\63fe311e-06a7-4b84-a142-50b502dedee5\Payload\tools\sdk\3.0.100-preview7-012630\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.TargetingPackResolution.targets(161,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [C:\dotnetbuild\work\63fe311e-06a7-4b84-a142-50b502dedee5\Work\89d40cf2-66b1-44ee-83e4-cc4823501d07\Unzip\netcoreapp3.0\project.csproj]

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jul 19, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: corefx-ci, corefx-ci (Windows x86_Release), corefx-ci (Windows x64_Debug), corefx-ci (Packaging All Configurations x64_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@stephentoub stephentoub force-pushed the darc-master-d2b9090e-1b05-4420-81c4-cb6624abb1da branch from 4c721cf to f1120c3 Compare July 19, 2019 14:27
@@ -8,7 +8,6 @@
<clear />
<add key="dotnet-core" value="https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json" />
<add key="dotnet-coreclr" value="https://dotnetfeed.blob.core.windows.net/dotnet-coreclr/index.json" />
<!-- TODO: Remove when an updated coverlet.console package is pushed to nuget.org. Issue: #39595 -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👿👿👿

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm the bot removed the comment:

4f9928f

I wonder why? @riarenas

@safern
Copy link
Member

safern commented Jul 19, 2019

Investigating the failure, it is because we don't have a 5.0 targeting pack in the SDK yet and we're trying to test against a 5.0 RuntimeFrameworkVersion in the 3.0 package testing.

The fix will be a bigger change that might involve a change in arcade. Already taking care of the fix.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jul 19, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: corefx-ci, corefx-ci (Windows x86_Release), corefx-ci (Windows x64_Debug), corefx-ci (Packaging All Configurations x64_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@safern
Copy link
Member

safern commented Jul 19, 2019

@ericstj could you please review commit: 345d0b1

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jul 19, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: corefx-ci, corefx-ci (Linux arm64_Debug), corefx-ci (Linux musl_arm64_Debug), corefx-ci (MacOS x64_Debug), corefx-ci (Linux arm_Debug), corefx-ci (Linux musl_x64_Debug), corefx-ci (Windows UWP_CoreCLR_x64_Debug), corefx-ci (Linux x64_Debug), corefx-ci (Windows NETFX_x86_Release), corefx-ci (Linux RedHat6_x64_Release), corefx-ci (Windows x86_Release), corefx-ci (Windows x64_Debug), corefx-ci (Packaging All Configurations x64_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@safern
Copy link
Member

safern commented Jul 19, 2019

cc: @wtgodbe FYI on what I had to do for package testing now that we rebranded to 5.0

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jul 19, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: corefx-ci, corefx-ci (Windows x86_Release), corefx-ci (Linux x64_Debug), corefx-ci (Packaging All Configurations x64_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

dotnet-maestro and others added 2 commits July 20, 2019 20:40
@stephentoub stephentoub force-pushed the darc-master-d2b9090e-1b05-4420-81c4-cb6624abb1da branch from 2a92c01 to 345d0b1 Compare July 21, 2019 00:40
dotnet-maestro added 2 commits July 21, 2019 12:28
…720.5

- runtime.native.System.IO.Ports - 5.0.0-alpha1.19370.5
- Microsoft.NETCore.Platforms - 5.0.0-alpha1.19370.5
…90720.2

- NETStandard.Library - 2.2.0-prerelease.19370.2
@safern
Copy link
Member

safern commented Jul 23, 2019

Closing in favor of: #39662

@safern safern closed this Jul 23, 2019
@safern safern deleted the darc-master-d2b9090e-1b05-4420-81c4-cb6624abb1da branch July 23, 2019 00:03
@karelz karelz added this to the 5.0 milestone Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants