add RID for new FreeBSD releases #41794
Conversation
| @@ -99,7 +99,7 @@ | |||
| <RuntimeGroup Include="freebsd"> | |||
| <Parent>unix</Parent> | |||
| <Architectures>x64</Architectures> | |||
| <Versions>11;11.0;11.1;11.2;11.3</Versions> | |||
| <Versions>11;12;13</Versions> | |||
There was a problem hiding this comment.
I don't think we've ever removed anything.... is that safe to do, @ericstj?
There was a problem hiding this comment.
I imagine that would be breaking. We need to look at what the RID calculation algorithm is doing on those releases to understand if its safe to omit the minor version.
There was a problem hiding this comment.
I was wondering the same. However never really had FreeBSD support so I thought it would be OK and easier to drag forward.
There was a problem hiding this comment.
@wfurt did you investigate what the host calculates as a RID on these releases? https://github.com/dotnet/core-setup/blob/b2bff948e10f7632a40799808f4d7c74b912df80/src/corehost/common/pal.unix.cpp#L445
how about platform abstractions? https://github.com/dotnet/core-setup/blob/master/src/managed/Microsoft.DotNet.PlatformAbstractions/RuntimeEnvironment.cs#L31-L36
There was a problem hiding this comment.
core-setup/get_current_os_rid_platform will get freebsd.11 and freebsd.12 PlatformApis.GetOSVersion will do the same.
There was a problem hiding this comment.
Do you have any more thoughts on this @ericstj ?
There was a problem hiding this comment.
Sure, if you've confirmed through testing that minor version is omitted from these and they are never actually used than I'm fine removing them.
Commit migrated from dotnet/corefx@32d103e
This adds entry for FreeBSD 12 (stable) and Freebsd 13 (snapshots)
I used #41397 as example and dropped minor versions so we will track only major releases like we do for Centos. Based on my testing, binaries build on 11.x works fine on 12 (with already submitted threading fix) so I see no reason to track them separate. I have not done testing on 13 but I assume it will be similar. When we did builds last time we used
freebsd-x64cc: @jasonpugsley
fixes #40865