This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Store Description value of ConfigurationProperty 2 #41873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm relatively sure that this will cause a test failure in the netfx leg 😄 |
|
yeah, but what's wrong with netfx? |
NetFX is .NET Framework. We run the tests against it. It still has the bug so the test will fail. You can attribute the new test to only run on core or use the |
|
And apologies for not noticing that the PR didn't actually trigger the runs. I've been a little under the weather. 🙏 |
|
Thank you very much! |
ViktorHofer
approved these changes
Oct 18, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Store Description value of ConfigurationProperty * Skip test on the .NET Framework Commit migrated from dotnet/corefx@2b92fc0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreate PR to trigger CI
Because this one #41842 was reverted by #41848