This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.1] Port polymorphic perf and better dictionary support #42008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * Populate non-immutable collections directly on deserialize (rather than storing in temporary collections and using converters to create and populate instances) * Fix deserilizing nested dictionaries * Don't get add method for types we can populate without reflection; fix failing tests * Misc perf changes * Additional changes * More changes * Address review feedback * Address feedback
* Cache polymorphic properties * Move RuntimePropertyCache to JsonClassInfo * Added test of RuntimePropertyCache using properties with different attributes * Fixed typo Co-Authored-By: Ahson Khan <ahkha@microsoft.com> * Use allocating overload of GetOrAdd on .Net Standard 2.0
steveharter
added
* NO SQUASH *
stephentoub
changed the title
steveharter
changed the title
This was referenced Oct 23, 2019
steveharter
added
the
* NO MERGE *
|
Closing since replaced by the two individual PRs mentioned in the description. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: the fixes for these two issues now exist in PRs #42057 and #42050 since these do not take the dependency on #42009 which may not be accepted.
note: the branch here is based on @layomia current branch for another issue which is not yet in 3.1 so you can ignore the first commit here. The next two commits handle two separate issues but since they conflict, just one PR:
Ports the following to release/3.1
#41753
#41903
Issues:
IDictionary<TKey, TValue>but do not implement the non-genericIDictionaryDescription
GetEnumerator()(either through theIEnumerableorIDictionaryinterfaces) returns anIDictionaryEnumerableas required for types that implementIDictionary. However, there are certain "newer" generic collection types outside of the BCL that don't implementIDictionaryor returnIDictionaryEnumerablefrom theirIEnumerable.GetEnumerator()method (note thatIDictionary<TKey, TValue>does not implementIDictionary). This caused aInvalidCastExceptionat runtime. The fix is to assumeIEnumerable<KeyValuePair<TKey, TValue>>instead ofIDictionaryEnumerablefor generic dictionaries.Customer Impact
IDictionary.Regression?
No. For the dictionary issue, the
InvalidCastExceptionis no longer encountered.Risk
Low.
The performance issue is very specific to polymorphic serialization and was already tested. An additional test was added to verify the cache is properly keying.
For the dictionary issue, existing tests were not modified and new tests added that only implement the generic
IDictionary<TKey, TValue>.