This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Porting OleDb transaction API failure fix #42878
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Port the changes from PR dotnet/runtime#32573
The changes address dotnet/runtime#31177 and dotnet/runtime#32405
The problem manifests in the usage of OleDbTransaction throwing exceptions in System.Data.OleDb. This is caused because a duplicate interface but with incorrect Guid for ITransaction.
The fix removes the duplicate interface and also releases the COM objects once they have been used.
Customer Impact
The customers will be able to use OleDbTransaction.Commit() and OleDbTransaction.RollBack(), successfully. These APIs are important to perform actions on OleDb providers with transaction support.
Also OleDbConnection.Dispose() would call OleDbTransaction.Rollback(), which used to fail silently underneath. These above issues would be addressed for customer.
Regression?
This is not a regression, and the bug had existed since the beginning.
Risk
No risks identified.
Packaging changes reviewed? (if a libraries change)
Package changes added after getting guidance from @Anipik