Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting OleDb transaction API failure fix #42878

Merged
merged 3 commits into from Mar 25, 2020
Merged

Conversation

@saurabh500
Copy link
Member

saurabh500 commented Mar 10, 2020

Description

Port the changes from PR dotnet/runtime#32573
The changes address dotnet/runtime#31177 and dotnet/runtime#32405

The problem manifests in the usage of OleDbTransaction throwing exceptions in System.Data.OleDb. This is caused because a duplicate interface but with incorrect Guid for ITransaction.
The fix removes the duplicate interface and also releases the COM objects once they have been used.

Customer Impact

The customers will be able to use OleDbTransaction.Commit() and OleDbTransaction.RollBack(), successfully. These APIs are important to perform actions on OleDb providers with transaction support.
Also OleDbConnection.Dispose() would call OleDbTransaction.Rollback(), which used to fail silently underneath. These above issues would be addressed for customer.

Regression?

This is not a regression, and the bug had existed since the beginning.

Risk

No risks identified.

Packaging changes reviewed? (if a libraries change)

Package changes added after getting guidance from @Anipik

@saurabh500 saurabh500 requested a review from Anipik Mar 10, 2020
@saurabh500 saurabh500 added this to the 3.1.x milestone Mar 10, 2020
@saurabh500 saurabh500 requested a review from maryamariyan Mar 10, 2020
@saurabh500 saurabh500 self-assigned this Mar 10, 2020
@Anipik
Anipik approved these changes Mar 10, 2020
Copy link
Member

Anipik left a comment

Packaging changes looks good. Still needs an approval from tactics and area owner

@Anipik Anipik added the * NO MERGE * label Mar 10, 2020
@saurabh500 saurabh500 requested a review from jkotas Mar 10, 2020
@jkotas
jkotas approved these changes Mar 10, 2020
@jamshedd

This comment has been minimized.

Copy link
Member

jamshedd commented Mar 10, 2020

Approved for 3.1.4.

@saurabh500

This comment has been minimized.

Copy link
Member Author

saurabh500 commented Mar 10, 2020

@jamshedd @danmosemsft @Anipik
From what I understood from the one note, I don't have to merge the PR, but I am not sure if that applies to non repo members or to members as well? If the CI is green, should I squash and merge this or wait for the next train and the DRI to merge this ?

@danmosemsft

This comment has been minimized.

Copy link
Member

danmosemsft commented Mar 10, 2020

@Anipik will merge. your work here is done hopefully 😄

@danmosemsft danmosemsft modified the milestones: 3.1.x, 3.1.4 Mar 19, 2020
@Anipik Anipik removed the * NO MERGE * label Mar 25, 2020
@Anipik Anipik merged commit d290666 into dotnet:release/3.1 Mar 25, 2020
15 checks passed
15 checks passed
WIP Ready for review
Details
corefx-ci Build #20200325.8 succeeded
Details
corefx-ci (Linux Build RedHat6_x64_Release) Linux Build RedHat6_x64_Release succeeded
Details
corefx-ci (Linux Build arm64_Debug) Linux Build arm64_Debug succeeded
Details
corefx-ci (Linux Build arm_Debug) Linux Build arm_Debug succeeded
Details
corefx-ci (Linux Build musl_arm64_Debug) Linux Build musl_arm64_Debug succeeded
Details
corefx-ci (Linux Build musl_x64_Debug) Linux Build musl_x64_Debug succeeded
Details
corefx-ci (Linux Build x64_Debug) Linux Build x64_Debug succeeded
Details
corefx-ci (MacOS Build x64_Debug) MacOS Build x64_Debug succeeded
Details
corefx-ci (Windows Build NETFX_x86_Release) Windows Build NETFX_x86_Release succeeded
Details
corefx-ci (Windows Build UWP_CoreCLR_x64_Debug) Windows Build UWP_CoreCLR_x64_Debug succeeded
Details
corefx-ci (Windows Build x64_Debug) Windows Build x64_Debug succeeded
Details
corefx-ci (Windows Build x86_Release) Windows Build x86_Release succeeded
Details
corefx-ci (Windows Packaging All Configurations x64_Debug) Windows Packaging All Configurations x64_Debug succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.