Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Porting OleDb transaction API failure fix #42878

Merged
merged 3 commits into from Mar 25, 2020
Merged

Conversation

saurabh500
Copy link
Contributor

@saurabh500 saurabh500 commented Mar 10, 2020

Description

Port the changes from PR dotnet/runtime#32573
The changes address dotnet/runtime#31177 and dotnet/runtime#32405

The problem manifests in the usage of OleDbTransaction throwing exceptions in System.Data.OleDb. This is caused because a duplicate interface but with incorrect Guid for ITransaction.
The fix removes the duplicate interface and also releases the COM objects once they have been used.

Customer Impact

The customers will be able to use OleDbTransaction.Commit() and OleDbTransaction.RollBack(), successfully. These APIs are important to perform actions on OleDb providers with transaction support.
Also OleDbConnection.Dispose() would call OleDbTransaction.Rollback(), which used to fail silently underneath. These above issues would be addressed for customer.

Regression?

This is not a regression, and the bug had existed since the beginning.

Risk

No risks identified.

Packaging changes reviewed? (if a libraries change)

Package changes added after getting guidance from @Anipik

@saurabh500 saurabh500 requested a review from Anipik March 10, 2020 12:46
@saurabh500 saurabh500 added the Servicing-consider Issue for next servicing release review label Mar 10, 2020
@saurabh500 saurabh500 added this to the 3.1.x milestone Mar 10, 2020
@saurabh500 saurabh500 self-assigned this Mar 10, 2020
Copy link

@Anipik Anipik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Packaging changes looks good. Still needs an approval from tactics and area owner

@Anipik Anipik added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Mar 10, 2020
@saurabh500 saurabh500 requested a review from jkotas March 10, 2020 12:58
@jamshedd jamshedd added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Mar 10, 2020
@jamshedd
Copy link
Member

Approved for 3.1.4.

@saurabh500
Copy link
Contributor Author

@jamshedd @danmosemsft @Anipik
From what I understood from the one note, I don't have to merge the PR, but I am not sure if that applies to non repo members or to members as well? If the CI is green, should I squash and merge this or wait for the next train and the DRI to merge this ?

@danmoseley
Copy link
Member

@Anipik will merge. your work here is done hopefully 😄

@danmoseley danmoseley modified the milestones: 3.1.x, 3.1.4 Mar 19, 2020
@Anipik Anipik removed the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Mar 25, 2020
@Anipik Anipik merged commit d290666 into dotnet:release/3.1 Mar 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Data Servicing-approved Approved for servicing release
Projects
None yet
6 participants