-
Notifications
You must be signed in to change notification settings - Fork 5k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Anipik does the PackageVersion need to be incremented here as well and the package explicitly marked to be built?
yes we need to do the same things here as we did in 3.1 and 5.0 |
Wasn't that already done via #43024 ? |
its fedora35 |
I meant updating the package version 😄 Edit: To elaborate, #43024 updates PackageVersion. Is this anything additional that needs to be done in this PR here? |
correct but it wont probably shipped in this release, it will be shipped in the next release |
The branches are already closed for march release. |
Hey @Anipik! Can you help me understand what exact changes I need to make to this PR? I updated |
854dd6d
to
10005a6
Compare
here is an example https://github.com/dotnet/corefx/blob/release/2.1/src/packages.builds#L27 |
Thanks! But since that line is already present in the 2.1 branch, I am not sure how to add it again.,, |
Yeah we need to wait for the release |
@omajid the release/2.1 branch needs to be "reset" to accommodate for the next servicing release which involves updating the branding and resetting the list of packages that should be built. We plan to make this easier with 6.0 LTS (i.e. sourcebuild RID support, defining packages that should be built directly in their project file, getting rid of the package index, ...). |
Is the repo open now? |
Yes the repo is open, @omajid can you add the packaging changes(packages.builds file and packageindex changes.) |
10005a6
to
35317cc
Compare
$ podman run -it registry.fedoraproject.org/fedora:rawhide /bin/bash -c 'cat /etc/os-release' NAME=Fedora VERSION="35 (Container Image Prerelease)" ID=fedora VERSION_ID=35 VERSION_CODENAME="" PLATFORM_ID="platform:f35" PRETTY_NAME="Fedora 35 (Container Image Prerelease)" ANSI_COLOR="0;38;2;60;110;180" LOGO=fedora-logo-icon CPE_NAME="cpe:/o:fedoraproject:fedora:35" HOME_URL="https://fedoraproject.org/" DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/rawhide/system-administrators-guide/" SUPPORT_URL="https://fedoraproject.org/wiki/Communicating_and_getting_help" BUG_REPORT_URL="https://bugzilla.redhat.com/" REDHAT_BUGZILLA_PRODUCT="Fedora" REDHAT_BUGZILLA_PRODUCT_VERSION=rawhide REDHAT_SUPPORT_PRODUCT="Fedora" REDHAT_SUPPORT_PRODUCT_VERSION=rawhide PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy" VARIANT="Container Image" VARIANT_ID=container This is a backport of dotnet/runtime#48200.
35317cc
to
127ae16
Compare
I updated the |
@ViktorHofer can you please approve? Do wee need service approval? |
AFAIK, RID updates are tell-mode. |
Just for the clarification: Is for tell-mode review approve enough? Is there a group op people who should participate in the review? |
Tell mode means letting your M2 and/or Tactics know but not seeking their approval. Usually the release managers and/or infra crew would review and approve such a change. |
This is a backport of dotnet/runtime#48200.