Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

[release/2.1] Add Fedora 35 RID #43033

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

omajid
Copy link
Member

@omajid omajid commented Feb 12, 2021

$ podman run -it registry.fedoraproject.org/fedora:rawhide /bin/bash -c 'cat /etc/os-release'
NAME=Fedora
VERSION="35 (Container Image Prerelease)"
ID=fedora
VERSION_ID=35
VERSION_CODENAME=""
PLATFORM_ID="platform:f35"
PRETTY_NAME="Fedora 35 (Container Image Prerelease)"
ANSI_COLOR="0;38;2;60;110;180"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:35"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/rawhide/system-administrators-guide/"
SUPPORT_URL="https://fedoraproject.org/wiki/Communicating_and_getting_help"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=rawhide
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=rawhide
PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
VARIANT="Container Image"
VARIANT_ID=container

This is a backport of dotnet/runtime#48200.

@omajid omajid changed the title Add Fedora 35 RID [release/2.1] Add Fedora 35 RID Feb 12, 2021
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anipik does the PackageVersion need to be incremented here as well and the package explicitly marked to be built?

@Anipik
Copy link

Anipik commented Feb 12, 2021

@Anipik does the PackageVersion need to be incremented here as well and the package explicitly marked to be built?

yes we need to do the same things here as we did in 3.1 and 5.0

@omajid
Copy link
Member Author

omajid commented Feb 12, 2021

Wasn't that already done via #43024 ?

@Anipik
Copy link

Anipik commented Feb 12, 2021

Wasn't that already done via #43024 ?

its fedora35

@omajid
Copy link
Member Author

omajid commented Feb 12, 2021

I meant updating the package version 😄

Edit: To elaborate, #43024 updates PackageVersion. Is this anything additional that needs to be done in this PR here?

@Anipik
Copy link

Anipik commented Feb 12, 2021

I meant updating the package version 😄

correct but it wont probably shipped in this release, it will be shipped in the next release

@Anipik
Copy link

Anipik commented Feb 12, 2021

The branches are already closed for march release.

@omajid
Copy link
Member Author

omajid commented Feb 24, 2021

Hey @Anipik! Can you help me understand what exact changes I need to make to this PR?

I updated pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj; do I need to somehow update src/packages.builds as well?

@Anipik
Copy link

Anipik commented Feb 24, 2021

@omajid
Copy link
Member Author

omajid commented Feb 24, 2021

Thanks!

But since that line is already present in the 2.1 branch, I am not sure how to add it again.,,

@Anipik
Copy link

Anipik commented Feb 24, 2021

Yeah we need to wait for the release

@ViktorHofer
Copy link
Member

ViktorHofer commented Feb 24, 2021

@omajid the release/2.1 branch needs to be "reset" to accommodate for the next servicing release which involves updating the branding and resetting the list of packages that should be built. We plan to make this easier with 6.0 LTS (i.e. sourcebuild RID support, defining packages that should be built directly in their project file, getting rid of the package index, ...).

@omajid
Copy link
Member Author

omajid commented Mar 9, 2021

Is the repo open now?

@aik-jahoda
Copy link

@omajid, @Anipik, can you please confirm all requested changes are in place?

@Anipik
Copy link

Anipik commented Mar 10, 2021

Yes the repo is open, @omajid can you add the packaging changes(packages.builds file and packageindex changes.)

    $ podman run -it registry.fedoraproject.org/fedora:rawhide /bin/bash -c 'cat /etc/os-release'
    NAME=Fedora
    VERSION="35 (Container Image Prerelease)"
    ID=fedora
    VERSION_ID=35
    VERSION_CODENAME=""
    PLATFORM_ID="platform:f35"
    PRETTY_NAME="Fedora 35 (Container Image Prerelease)"
    ANSI_COLOR="0;38;2;60;110;180"
    LOGO=fedora-logo-icon
    CPE_NAME="cpe:/o:fedoraproject:fedora:35"
    HOME_URL="https://fedoraproject.org/"
    DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/rawhide/system-administrators-guide/"
    SUPPORT_URL="https://fedoraproject.org/wiki/Communicating_and_getting_help"
    BUG_REPORT_URL="https://bugzilla.redhat.com/"
    REDHAT_BUGZILLA_PRODUCT="Fedora"
    REDHAT_BUGZILLA_PRODUCT_VERSION=rawhide
    REDHAT_SUPPORT_PRODUCT="Fedora"
    REDHAT_SUPPORT_PRODUCT_VERSION=rawhide
    PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
    VARIANT="Container Image"
    VARIANT_ID=container

This is a backport of dotnet/runtime#48200.
@omajid
Copy link
Member Author

omajid commented Mar 10, 2021

I updated the packages.builds file. The packgesIndex.json didn't get updated on build. I manually added the new version 2.1.14 to it.

@aik-jahoda
Copy link

aik-jahoda commented Mar 11, 2021

@ViktorHofer can you please approve? Do wee need service approval?

@omajid
Copy link
Member Author

omajid commented Mar 11, 2021

AFAIK, RID updates are tell-mode.

@aik-jahoda
Copy link

Just for the clarification: Is for tell-mode review approve enough? Is there a group op people who should participate in the review?

@aik-jahoda aik-jahoda merged commit b028947 into dotnet:release/2.1 Mar 11, 2021
@ViktorHofer
Copy link
Member

Tell mode means letting your M2 and/or Tactics know but not seeking their approval. Usually the release managers and/or infra crew would review and approve such a change.

@ViktorHofer ViktorHofer added the Servicing-approved Approved for servicing release label May 10, 2021
@rbhanda rbhanda added this to the 2.1.18 milestone May 10, 2021
@ViktorHofer ViktorHofer modified the milestones: 2.1.18, 2.1.28 May 10, 2021
@omajid omajid mentioned this pull request Jul 9, 2021
15 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
6 participants