This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix #320 - InvalidProgramException on .NET < 4.5.2 on x64 #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguerrera
force-pushed
the
workaround-320
branch
from
fdef977
to
7aa3c8d
Compare
nguerrera
changed the title
|
Note about testing: simply running our unit tests with a release build on .NET 4.5 RTM x64 causes 79 failures due to this issue. However, our infrastructure is not setup to run in that configuration at the moment. |
In .NET 4.5 and .NET 4.5.1 on x64, the JIT would attempt to inline a particular generic method, which would cause it to bail with an InvalidProgramException. Workaround the issue by applying MethodImplOptions.NoInlining to the method. There is no perf loss because the whole purpose of this method is to throw in the failure case and it is factored out precisely to help the inlining of its callers. The JIT bug has already been fixed in .NET 4.5.2, but we support immutable collections on .NET 4.5 and .NET 4.5.1 as well, which is why we must workaround the issue.
nguerrera
force-pushed
the
workaround-320
branch
from
7aa3c8d
to
534c6e7
Compare
|
LGTM. Sounds like a fun one to track down :-). |
|
Thanks, @ellismg. Yes, fun. :) |
nguerrera
added a commit
that referenced
this pull request
Feb 7, 2015
Fix #320 - InvalidProgramException on .NET < 4.5.2 on x64
|
LGTM. Nice work tracking it down. |
|
@nguerrera OK, agreed. Usage of typeof(T) is rare enough. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In .NET 4.5 and .NET 4.5.1 on x64, the JIT would attempt to inline a
particular generic method, which would cause it to bail with an
InvalidProgramException.
Workaround the issue by applying MethodImplOptions.NoInlining to the
method. There is no perf loss because the whole purpose of this method
is to throw in the failure case and it is factored out precisely to
help the inlining of its callers.
The JIT bug has already been fixed in .NET 4.5.2, but we support
immutable collections on .NET 4.5 and .NET 4.5.1 as well, which is
why we must workaround the issue.