Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

HTTP headers are ASCII not UTF8 #182

Closed
benaadams opened this issue Aug 13, 2015 · 1 comment
Closed

HTTP headers are ASCII not UTF8 #182

benaadams opened this issue Aug 13, 2015 · 1 comment
Assignees
Labels
area-System.Text.Http OpenBeforeArchiving These issues were open before the repo was archived. For re-open them, file them in the new repo
Milestone

Comments

@benaadams
Copy link
Member

https://tools.ietf.org/html/rfc7230#section-3.2.4

Historically, HTTP has allowed field content with text in the
ISO-8859-1 charset [ISO-8859-1], supporting other charsets only
through use of [RFC2047] encoding. In practice, most HTTP header
field values use only a subset of the US-ASCII charset [USASCII].
Newly defined header fields SHOULD limit their field values to
US-ASCII octets. A recipient SHOULD treat other octets in field
content (obs-text) as opaque data.

So https://github.com/dotnet/corefxlab/blob/master/demos/LowAllocationWebServer/HttpRequestParser.cs
should be parsing bytes based on US-ASCII rather than UTF8 data

@KrzysztofCwalina
Copy link
Member

Good to know. When we add validation to the code we will make sure non-ascii characters are handled properly.

@joshfree joshfree assigned ahsonkhan and unassigned livarcocc Jan 9, 2017
@ahsonkhan ahsonkhan modified the milestones: Future, 2.1.0 Apr 6, 2017
@joshfree joshfree modified the milestones: 2.1.0, Future Apr 5, 2018
@pgovind pgovind added the OpenBeforeArchiving These issues were open before the repo was archived. For re-open them, file them in the new repo label Mar 11, 2021
@pgovind pgovind closed this as completed Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.Http OpenBeforeArchiving These issues were open before the repo was archived. For re-open them, file them in the new repo
Projects
None yet
Development

No branches or pull requests

7 participants