Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

CoreLib doesn't implement Environment.GetEnvironmentVariable and friends #6

Closed
MichalStrehovsky opened this issue Sep 24, 2015 · 3 comments · Fixed by #147
Closed
Assignees
Milestone

Comments

@MichalStrehovsky
Copy link
Member

GetEnvironmentVariable and ExpandEnvironment are implemented like this:

public static String GetEnvironmentVariable(String variable)
{
    if (variable == null)
        throw new ArgumentNullException("variable");

    // Environment variable accessors are not approved modern API.
    // Behave as if the variable was not found in this case.
    return null;
}

We need real implementations.

@weshaggard
Copy link
Member

Yes that was their implementation for UWP. I agree we need this supported for this scenario. @AlexGhiondea should be able to handle it.

@MichalStrehovsky MichalStrehovsky added this to the P0 milestone Oct 28, 2015
@MichalStrehovsky
Copy link
Member Author

We might need to at least look at this in terms of the demo.

System.Console uses this for various things. I didn't investigate it now fully, but this did show up at some point when I did the original Hello World ILToCpp bringup. It's possible it was only needed for colors, but I don't remember anymore.

@AlexGhiondea
Copy link
Contributor

I have a hacked version of this working on windows already. I will finalize it tomorrow and then I'll get the PAL implemented on Linux (we already have a cross plat implementation in CoreCLR for this).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants