New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CppCodeGen] Managed Exception Dispatch and Unwind #910

Open
jkotas opened this Issue Feb 21, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@jkotas
Copy link
Member

jkotas commented Feb 21, 2016

static void Main() {
     try {
          throw new Exception();
    }
    catch {
          Console.WriteLine("Exception caught");
    }
}
@AlexBHarley

This comment has been minimized.

Copy link

AlexBHarley commented Feb 21, 2016

@jkotas I have setup corert on my local machine. I compiled this with using RyuJIT and then CPP Code Generator. Both worked and caught the exception. Could you please let me know a bit more about the issue here?

@jkotas

This comment has been minimized.

Copy link
Member

jkotas commented Feb 21, 2016

I suspect that you are not actually running the code using CoreRT - exception handling does not work yet with either RyuJIT or CppCodeGen.

Try following steps in Documentation\how-to-build-and-run-ilcompiler-in-visual-studio-2015.md or Documentation\how-to-build-and-run-ilcompiler-in-console-shell-prompt.md. The Visual Studio steps are more convenient for day to day development, just change the repro project to throw and catch exception to see the crash when you run the program.

@MichalStrehovsky MichalStrehovsky added this to the Future milestone Oct 20, 2016

@jkotas

This comment has been minimized.

Copy link
Member

jkotas commented Jan 21, 2017

The plan should be:

  • Piggy back on C++ exception handling
  • Use explicit checks instead of hardware exceptions (e.g. explicit checks for null reference exceptions)

Unity IP2CPP internals blog shows example of possible way to do this. Mono LLVM pure bitcode backend has same problem and it uses similar scheme to solve it.

@hippiehunter

This comment has been minimized.

Copy link
Contributor

hippiehunter commented Sep 16, 2017

@jkotas
Relying on C++ Exception handling seems sub optimal, while it would solve stack walking for exceptions, there are overheads to using C++ Exception handling and none of the other uses of stack walking (GC and StackTrace) would be able to leverage that overhead.

I've been reading the Book of the Runtime section on stack walking and from what I can tell, in the JITed version, stack walking is implemented using a mapping of instruction pointer ranges to function definition metadata. Allowing the stack walker to unwind each frame by doing a lookup and then moving the stack pointer backwards (based on the size specified in the looked up metadata), repeatedly until it gets where it wants to.

This seems like the most performant solution to the problem, but while its possible to get the address of a function in C++, I don't see a (portable) way to get the address of the last instruction in a function. Is RIP mapping really a dead end or is there some kind of sentinel stack cookie way I'm overlooking.

@jkotas

This comment has been minimized.

Copy link
Member

jkotas commented Sep 16, 2017

Portability is primary goal for CppCodeGen, performance is secondary. I think the C++ exception handling is the best we can do without compromising portability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment