Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update absolute links to relative #7900

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update absolute links to relative #7900

wants to merge 4 commits into from

Conversation

Saisang
Copy link

@Saisang Saisang commented Feb 2, 2024

No description provided.

@Saisang Saisang requested a review from a team as a code owner February 2, 2024 06:22
333fred
333fred requested changes Feb 2, 2024
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links are not relative to this repository, so by doing this we'd make them not resolve in our markdown. What is the reason you're trying to change them?

@Saisang
Copy link
Author

Saisang commented Feb 4, 2024

These links are not relative to this repository, so by doing this we'd make them not resolve in our markdown. What is the reason you're trying to change them?

This is a kind of build suggestion in OPS. "Absolute link '{URL}' will be broken in isolated environments. Replace with a relative link." I'm trying to update all absolute links to relative ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Saisang @333fred