Remove use of "statement body" #999
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jskeet
added
the
meeting: discuss
Even though the precise context for the original definitions isn't applicable other times, it's simpler to just leave those as the sole definitions. The other uses are conceptually equivalent - it's not like we're actually defining different terms. Additionally, replace "statement body" with "block body" for both properties and indexers. Fixes dotnet#948. Fixes dotnet#877.
jskeet
force-pushed
the
fix-body-definitions
branch
from
51204bf
to
065b8c4
Compare
BillWagner
previously approved these changes
Nov 27, 2023
jskeet
commented
Nov 29, 2023
| @@ -3168,15 +3168,15 @@ The *member_name* ([§15.6.1](classes.md#1561-general)) specifies the name of th | |||
|
|
|||
| The *type* of a property shall be at least as accessible as the property itself ([§7.5.5](basic-concepts.md#755-accessibility-constraints)). | |||
|
|
|||
| A *property_body* may either consist of a ***statement body*** or an ***expression body***. In a statement body, *accessor_declarations*, which shall be enclosed in “`{`” and “`}`” tokens, declare the accessors ([§15.7.3](classes.md#1573-accessors)) of the property. The accessors specify the executable statements associated with reading and writing the property. | |||
| A *property_body* may either consist of a block body or an expression body. In a block body, *accessor_declarations*, which shall be enclosed in “`{`” and “`}`” tokens, declare the accessors ([§15.7.3](classes.md#1573-accessors)) of the property. The accessors specify the executable statements associated with reading and writing the property. | |||
There was a problem hiding this comment.
Note in discussion: this isn't right, but we don't have a good term yet. "Accessor body", "accessor section" and "accessor list" are some options discussed.
jskeet
commented
Nov 29, 2023
|
Assigned to myself for further work, and splitting into "just stars" and "just terms". |
|
Note to correlate the use of block and "expression body" on static constructor, instance constructors, and finalizers. |
jskeet
added
status: in-progress
jskeet
added a commit
to jskeet/csharpstandard
that referenced
this pull request
Nov 30, 2023
This is half of what dotnet#999 was trying to do; the rest requires some more work.
BillWagner
pushed a commit
that referenced
this pull request
Nov 30, 2023
This is half of what #999 was trying to do; the rest requires some more work.
jskeet
changed the title
|
(I'm not really requesting a review - I just wanted to remove the "approved" bit.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This was originally about both statement bodies and multiple definitions; the multiple definitions part has been done in #1019.)
Even though the precise context for the original definitions isn't applicable other times, it's simpler to just leave those as the sole definitions. The other uses are conceptually equivalent - it's not like we're actually defining different terms.
Additionally, replace "statement body" with "block body" for both properties and indexers.
Fixes #877.