Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include @dotnet/source-build-internal as code owners for SB files #319

Open
ellahathaway opened this issue Dec 8, 2023 · 2 comments
Open

Include @dotnet/source-build-internal as code owners for SB files #319

ellahathaway opened this issue Dec 8, 2023 · 2 comments
Assignees
@ellahathaway
Labels
area-Infrastructure

Comments

@ellahathaway
Copy link
Member

@dotnet/source-build-internal is not tagged as a code owner for SourceBuildPrebuiltBaseline.xml. It would be helpful to create a CODEOWNERS file and include source-build-internal on SB files. For reference, Aspnet does this in their CODEOWNERS file: https://github.com/dotnet/aspnetcore/blob/36c976723fd0b55dad80f1ff32e665800ea4a021/.github/CODEOWNERS#L19

Having a code owners file would also be generally useful when opening PRs in this repo, as it can sometimes be difficult and time consuming to determine who should be included as a reviewer.
@lbussell
Copy link
Contributor

lbussell commented Dec 8, 2023

Related issue: dotnet/arcade#9555

@NikolaMilosavljevic
Copy link
Member

[Triage] Approved - please fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ellahathaway ellahathaway

Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@MichaelSimons @NikolaMilosavljevic @lbussell @ellahathaway