Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to cross build for Alpine #4611

Closed
richlander opened this issue Apr 16, 2024 · 2 comments
Closed

Switch to cross build for Alpine #4611

richlander opened this issue Apr 16, 2024 · 2 comments
Labels
bug Something isn't working engineering
Milestone

Comments

@richlander
Copy link
Member

The Alpine build should switch to cross-build, like is done in dotnet/runtime.

Existing pattern:

image: mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.13-WithNode

Correct pattern:

https://github.com/dotnet/runtime/blob/564609591ac7ae7fdc87f69419b80308e1f1bef4/eng/pipelines/common/templates/pipeline-with-resources.yml#L36

We shouldn't be using old Alpine images.

The Azure Linux cross-build targets Alpine 3.13, so there is no loss in targeting. However, the newer image uses a much newer clang. As we discovered before (#4556), it will take some effort to make this repo compatible with a new toolset.

@mikem8361 @sbomer @hoyosjs

@richlander richlander added the bug Something isn't working label Apr 16, 2024
@tommcdon tommcdon added this to the 9.0.0 milestone Apr 16, 2024
@mikem8361
Copy link
Member

Should the diagnostics repo be using the azurelinux-3.0-* (instead of the current cbl-mariner-2.0-*) images for linux_arm, linux_arm64, linux_musl_arm, linux_musl_arm64, etc.?

For linux_x64 we are using mcr.microsoft.com/dotnet-buildtools/prereqs:centos-7 since SOS, etc. needs to run on older linux distros. Can we use mcr.microsoft.com/dotnet-buildtools/prereqs:azurelinux-3.0-cross-amd64-net8.0 like the runtime?

mikem8361 added a commit to mikem8361/diagnostics that referenced this issue Apr 17, 2024
mikem8361 added a commit to mikem8361/diagnostics that referenced this issue Apr 17, 2024
@richlander
Copy link
Member Author

We should continue using centos-7 for .NET 6 compat. That's what we're using everywhere else. You can move to azurelinux-3.0-cross-amd64-net8.0 once .NET 8 is the lowest version you need to support.

Yes, for now, the cbl-mariner images are a better choice. Once that is in place, we can move you to the azurelinux images pretty easily once the time is right (which will be within the next few months).

@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working engineering
Projects
None yet
Development

No branches or pull requests

3 participants