Implement SOS Hosting for Windows (dotnet-dump) #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defined all the dbgeng delegates needed to implement the subset of the IDebugClient and related interfaces to host SOS on Windows. Also modified various parts of the native SOS to be able to be hosted. Changed the Ext* and DML* output functions to formatted the output before sending it to IDebugControl::OutputVaList. There is no way to create a cdecl reverse pinvoke. The "args" OutputVaList is ignored when hosted. Changed from IDebugAdvanced3 to IDebugAdvanced. Cleanup (remove globals, etc.) exts.cpp DebugExtensionNotify code to make sure none of the globals initialized by the original code are used because these DebugExtensionInitialize, DebugExtensionNotify and DebugExtensionUninitialize are only called when sos is running under cdb/windbg. Simplified ProvideLibraryInternal (used by clrstack -i only) to work on a hosted sos. It originally was using dbgeng functions that can't be supported. Added 2.1 version of DumpTieredNativeCodeAddressInfo (not used yet). Enable dotnet-dump testing on Windows. Delete useless createdump commmand. Remove spurious error message in GetCoreClrDirectory. Update to latest symstore: 1.0.0-dev-64131-02. Update dummy native projects to 2019.
noahfalk
approved these changes
Jun 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defined all the dbgeng delegates needed to implement the subset of the
IDebugClient and related interfaces to host SOS on Windows. Also modified
various parts of the native SOS to be able to be hosted.
Changed the Ext* and DML* output functions to formatted the output before
sending it to IDebugControl::OutputVaList. There is no way to create a
cdecl reverse pinvoke. The "args" OutputVaList is ignored when hosted.
Changed from IDebugAdvanced3 to IDebugAdvanced.
Cleanup (remove globals, etc.) exts.cpp DebugExtensionNotify code to make sure
none of the globals initialized by the original code are used because these
DebugExtensionInitialize, DebugExtensionNotify and DebugExtensionUninitialize
are only called when sos is running under cdb/windbg.
Simplified ProvideLibraryInternal (used by clrstack -i only) to work on a hosted
sos. It originally was using dbgeng functions that can't be supported.
Added 2.1 version of DumpTieredNativeCodeAddressInfo (not used yet).
Enable dotnet-dump testing on Windows.
Delete useless createdump commmand.
Remove spurious error message in GetCoreClrDirectory.
Update to latest symstore: 1.0.0-dev-64131-02.
Update dummy native projects to 2019.