Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change metrics parsing to use InvariantCulture #3558

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Change metrics parsing to use InvariantCulture #3558

merged 1 commit into from
Dec 16, 2022

Conversation

ghord
Copy link
Contributor

@ghord ghord commented Dec 15, 2022

Changed parsing of event data to always use InvariantCulture.

Fixes #3542

@ghord ghord requested a review from a team as a code owner December 15, 2022 21:34
tommcdon
tommcdon approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@tommcdon tommcdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the contribution!

@hoyosjs
Copy link
Member

hoyosjs commented Dec 16, 2022

Failure is unrelated.

@hoyosjs hoyosjs merged commit 60cdc98 into dotnet:main Dec 16, 2022
@hoyosjs hoyosjs mentioned this pull request Feb 1, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommcdon tommcdon tommcdon approved these changes

@hoyosjs hoyosjs hoyosjs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Histogram/UpDownCounter counters are not shown when running dotnet counters tool
3 participants
@ghord @hoyosjs @tommcdon