Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup 1ES template changes #4596

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Followup 1ES template changes #4596

merged 4 commits into from
Apr 12, 2024

Conversation

mikem8361
Copy link
Member

Some cleanup and use the unofficial template for internal PR builds.

@mikem8361 mikem8361 requested a review from hoyosjs April 10, 2024 22:01
@mikem8361 mikem8361 self-assigned this Apr 10, 2024
eng/pipelines/templateUnofficial.yml Outdated Show resolved Hide resolved
eng/pipelines/templateUnofficial.yml Outdated Show resolved Hide resolved
eng/pipelines/templateUnofficial.yml Outdated Show resolved Hide resolved
Some cleanup and use the unofficial template for internal PR builds.
diagnostics.yml Outdated Show resolved Hide resolved
@mikem8361
Copy link
Member Author

@hoyosjs or @mdh1418 can you approve this PR? I have all the feedback resolved.

Copy link
Member

@mdh1418 mdh1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mikem8361 mikem8361 merged commit 1f6a0ea into dotnet:main Apr 12, 2024
18 checks passed
@mikem8361 mikem8361 deleted the 1es-followup branch April 12, 2024 20:46
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants