-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow tools to specify a specific OS transport #770
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little worried about the naming, but otherwise looks good : )
@josalem I remember us having a hallway conversation about using URIs for the address/transportPath (e.g., Is that no longer being considered? |
We just chatted about it offline, but I wanted to document it here. Making this a URI is an implementation detail that we can tackle later without changing the name/functionality added here. So, for now, I'm going to leave it out, but we can certainly add it if we ever add more transports. |
* Add IpcTransport to abstract pid and named connections
b502643
to
dff80ee
Compare
src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsIpc/IpcTransport.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsIpc/IpcTransport.cs
Outdated
Show resolved
Hide resolved
<Noah being pedantic> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'm closing this as the design of this feature has pivoted (see: dotnet/runtime#33307) a bit during development and this code needs to change accordingly. |
Once dotnet/runtime#1600 is merged in, the runtime will be able to create the diagnostics server transport at a specific location. This change allows the tools to consume the path to a Unix Domain Socket or a specific Named Pipe.
Example:
dotnet trace collect --transport-path /diagnostics/myapp.sock
The client library is also updated to allow for creating a
DiagnosticsClient
using astring
(for path) instead of anint
(for pid).CC - @shirhatti @tommcdon