Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dotnet-helix-service to .NET 8 #2413

Open
chcosta opened this issue Apr 1, 2024 · 7 comments
Open

Move dotnet-helix-service to .NET 8 #2413

chcosta opened this issue Apr 1, 2024 · 7 comments
Labels
Ops - Service Maintenance Used to track issues related to maintaining the services .NET Eng Supports

Comments

@chcosta
Copy link
Member

chcosta commented Apr 1, 2024

Moving this to its own issue from #1430

dotnet-helix-service cannot move to .NET 8 because it deploys to Service Fabric which does not yet provide a .NET 8 runtime.

Service fabric supported versions are listed here

ETA for .NET 8 support is June.

Related to this effort is #2412

Migration to .NET 8 was started, see this commit.

Sample build from the migration changes (the build times out during the deploy to Service Fabric step because of the lack of .NET 8 support) - https://dev.azure.com/dnceng/internal/_build/results?buildId=2418661&view=results

@AlitzelMendez
Copy link
Member

@chcosta the deployment to SF could be failing for other reasons, when this is run manually (as it was the build that you shared) the upgrade policy is different (it is the same as when we deploy in production) and it makes really hard to deploy in staging.

For example, the upgrade domain timeout is 11 minutes, and all the application should be healthy, all that is defined here: https://dev.azure.com/dnceng/internal/_git/dotnet-helix-service?path=/eng/deployment/app.bicep&version=GBmain&line=29&lineEnd=30&lineStartColumn=1&lineEndColumn=1&lineStyle=plain&_a=contents

so if we need to test this is staging we need to make sure that we are not monitoredUpgrade

@chcosta
Copy link
Member Author

chcosta commented Apr 1, 2024

@AlitzelMendez ,appreciate you, I'll take another look

@chcosta chcosta self-assigned this Apr 2, 2024
@chcosta
Copy link
Member Author

chcosta commented Apr 2, 2024

Ali was right about why deployment was failing. After temporarily changing the 'monitoredUpgrade' parameter of the deploymentParameters to $false for validation purposes (and retrying a few test failures), we now have a passing helix validation build.

https://dev.azure.com/dnceng/internal/_build/results?buildId=2420208&view=results

However, further validation (from Ali) shows that we do indeed have heavy reliance on the .NET runtime in the apps we run on service fabric and those will fail.

I am leaving my dev branch available for when SF supports .NET 8 runtime - chcosta/move-to-net8-nocg

@chcosta chcosta removed their assignment Apr 2, 2024
@markwilkie
Copy link
Member

markwilkie commented Apr 2, 2024 via email

@riarenas
Copy link
Member

riarenas commented Apr 2, 2024 via email

@riarenas
Copy link
Member

riarenas commented Apr 2, 2024

Here's the internal workitem: https://dev.azure.com/msazure/One/_workitems/edit/17509673. It seems to be going along!

@chcosta
Copy link
Member Author

chcosta commented Apr 2, 2024

says they are targeting April

I agree with everything Richie said, and I saw something recently that indicated they thought June was likely (I think based on historical data), but I'm not going to hunt it down. Regardless, it is likely that we will be stuck in this state until after .NET 7's EOL.

@ilyas1974 ilyas1974 added Ops - Service Maintenance Used to track issues related to maintaining the services .NET Eng Supports Ops - P2 Operations task, priority 2 and removed Ops - P2 Operations task, priority 2 labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ops - Service Maintenance Used to track issues related to maintaining the services .NET Eng Supports
Projects
None yet
Development

No branches or pull requests

5 participants