Pack DfmHttpService #1167
Pack DfmHttpService #1167
Conversation
qinezh
requested review from
vicancy,
hellosnow,
ansyral,
vwxyzh,
superyyrrzz and
chenkennt
| <requireLicenseAcceptance>true</requireLicenseAcceptance> | ||
| <licenseUrl>https://github.com/dotnet/docfx/blob/dev/LICENSE</licenseUrl> | ||
| <projectUrl>https://github.com/dotnet/docfx</projectUrl> | ||
| <description>This is a tool to generate API documentation for .NET projects.</description> |
There was a problem hiding this comment.
question: do wee need to update the description?
| src/nuspec/docfx.console/tools/*.dll | ||
| src/nuspec/docfx.console/tools/*.exe | ||
| src/nuspec/docfx.console/tools/*.exe.config | ||
| src/nuspec/docfx.console/tools/ |
There was a problem hiding this comment.
why ignoring everything in tools? install.ps1?
| function PackSelfContainProject { | ||
| param($sourceFolder, $nuspecPath) | ||
| $targetFolder = (Get-Item $nuspecPath).Directory.FullName | ||
| $null = New-Item -ItemType Directory -Force -Path "$targetFolder\tools\" |
There was a problem hiding this comment.
Copy to a target folder instead of doing it inside src folder $nuspecPath
| @@ -60,6 +60,18 @@ function NugetPack { | |||
| } | |||
| } | |||
|
|
|||
| function PackSelfContainProject { | |||
There was a problem hiding this comment.
PackSelfContainProject [](start = 9, length = 22)
PackSelfContainTool?
There was a problem hiding this comment.
I think Project here is better than Tool
There was a problem hiding this comment.
A bit confusing with NugetPack... which also pack self contain project
In reply to: 95931418 [](ancestors = 95931418)
There was a problem hiding this comment.
There was a problem hiding this comment.
|
|
1 similar comment
|
|
| src/nuspec/docfx.console/tools/*.exe.config | ||
| src/nuspec/AzureMarkdownRewriterTool/tools/ | ||
|
|
||
| PACK/ |
There was a problem hiding this comment.
PACK [](start = 0, length = 4)
reuse naming convention, e.g. DROP, TEMP, obj, ...
| @@ -60,6 +60,31 @@ function NugetPack { | |||
| } | |||
| } | |||
|
|
|||
| function PackSelfContainProject { | |||
There was a problem hiding this comment.
PackSelfContainProject [](start = 9, length = 22)
PackNuspecProject?
| Copy-Item -Path "$assemblyFolder\*.exe" -Destination "$targetFolder\tools\" -Force | ||
| Copy-Item -Path "$assemblyFolder\*.exe.config" -Destination "$targetFolder\tools\" -Force | ||
|
|
||
| & $nuget pack "$targetFolder\$nuspecName" -Version $version -OutputDirectory artifacts\$configuration |
There was a problem hiding this comment.
$version [](start = 55, length = 8)
param implicitly used?
There was a problem hiding this comment.
No description provided.