Add try catch and needed logging for a actionable message to the user. #8131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yufeih @superyyrrzz could you kindly help to review this PR? |
|
@saipramod The change looks good to me. BTW, could the code compile on your local machine? I see CI build is failing. |
@superyyrrzz : thanks for pointing this out. i fixed the missing import. |
saipramod
changed the title
superyyrrzz
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is for the issue - #8128
It adds a try catch to help log the name file which is causing issue when parsing pipe based table parser or any other parser. The reason for this logging is to help our customers be able to debug the issue themselves.