Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: some API page child namespaces 404 #9372

Merged
merged 3 commits into from
Nov 3, 2023
Merged

fix: some API page child namespaces 404 #9372

merged 3 commits into from
Nov 3, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Nov 3, 2023

Some child namespace links are 404 because due to not included in the output.

#9343

@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Nov 3, 2023
@yufeih yufeih marked this pull request as ready for review November 3, 2023 04:23
@codecov Codecov
Copy link

codecov bot commented Nov 3, 2023 •
edited
Loading

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/Docfx.Dotnet/DotnetApiCatalog.ApiPage.cs 0.00% <0.00%> (ø)
...ocfx.Build/TemplateProcessors/TemplateProcessor.cs 64.13% <46.15%> (-14.45%) ⬇️

📢 Thoughts on this report? Let us know!.

@yufeih yufeih merged commit b71aea7 into main Nov 3, 2023
7 checks passed
@yufeih yufeih deleted the fixns branch November 3, 2023 06:40
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
@yufeih @p-kostov
fix: some API page child namespaces 404 (dotnet#9372)
9b71685
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@yufeih