Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add warnings for UnresolvedAnalyzerReference #9623

Merged
merged 2 commits into from
Jan 20, 2024

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Jan 18, 2024

What's included in this PR
Add warning logs for UnresolvedAnalyzerReference.
(That occurs when analyzer DLL can't resolved when running dotnet metadata command.
See: #9619

Test
I've tested PR manually with solution that contains SourceGenerator project.

Warning message examples

warning: There is .NET Analyzer that can't be resolved. Path: C:\Projects\SampleApp\src\SampleSourceGenerator\bin\Release\netstandard2.0\SampleSourceGenerator.dll

@paulushub
Copy link

@filzrev Is it possible to detect such case and automatically fix it (re-running)?

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (2c5f8ea) 74.32% compared to head (8230f09) 74.31%.
Report is 5 commits behind head on main.

Files Patch % Lines
src/Docfx.Dotnet/DotnetApiCatalog.Compile.cs 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9623      +/-   ##
==========================================
- Coverage   74.32%   74.31%   -0.02%     
==========================================
  Files         536      536              
  Lines       23169    23173       +4     
  Branches     4053     4054       +1     
==========================================
  Hits        17220    17220              
- Misses       4848     4851       +3     
- Partials     1101     1102       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yufeih yufeih merged commit 643f73a into dotnet:main Jan 20, 2024
8 checks passed
@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Jan 27, 2024
@filzrev filzrev deleted the chore-add-unresolved-analyzer-warning branch April 1, 2024 05:03
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants