Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add control event articles #1113

Merged
merged 7 commits into from
Jul 19, 2021
Merged

Add control event articles #1113

merged 7 commits into from
Jul 19, 2021

Conversation

adegeo
Copy link
Contributor

@adegeo adegeo commented Jul 16, 2021

Summary

  • Added events overview for controls.
  • Added How to handle events.
  • Moved a common image to the shared folder.

Contributes to #76

@luisquintanilla

Preview Links:

File Type File Name Published Url
Content dotnet-desktop-guide/net/winforms/controls/events.md https://review.docs.microsoft.com/en-us/dotnet/desktop/winforms/controls/events?view=netdesktop-5.0&branch=pr-en-us-1113
Content dotnet-desktop-guide/net/winforms/controls/how-to-add-an-event-handler.md https://review.docs.microsoft.com/en-us/dotnet/desktop/winforms/controls/how-to-add-an-event-handler?view=netdesktop-5.0&branch=pr-en-us-1113
Content dotnet-desktop-guide/framework/winforms/controls/how-to-add-an-event-handler.md https://review.docs.microsoft.com/en-us/dotnet/desktop/winforms/controls/how-to-add-an-event-handler?view=netframeworkdesktop-4.8&branch=pr-en-us-1113
Content dotnet-desktop-guide/net/winforms/controls/how-to-add-a-picture-to-a-control.md https://review.docs.microsoft.com/en-us/dotnet/desktop/winforms/controls/how-to-add-a-picture-to-a-control?view=netdesktop-5.0&branch=pr-en-us-1113
Content dotnet-desktop-guide/net/winforms/controls/how-to-set-the-display-text.md https://review.docs.microsoft.com/en-us/dotnet/desktop/winforms/controls/how-to-set-the-display-text?view=netdesktop-5.0&branch=pr-en-us-1113
Content dotnet-desktop-guide/net/winforms/how-to-connect-multiple-events-to-a-single-event-handler-in-windows-forms.md https://review.docs.microsoft.com/en-us/dotnet/desktop/winforms/how-to-connect-multiple-events-to-a-single-event-handler-in-windows-forms?view=netdesktop-5.0&branch=pr-en-us-1113
Content dotnet-desktop-guide/net/winforms/how-to-create-event-handlers-at-run-time-for-windows-forms.md https://review.docs.microsoft.com/en-us/dotnet/desktop/winforms/how-to-create-event-handlers-at-run-time-for-windows-forms?view=netdesktop-5.0&branch=pr-en-us-1113
Resource dotnet-desktop-guide/net/winforms/controls/media/how-to-add-an-event-handler/visual-studio-properties-events-click.png https://review.docs.microsoft.com/en-us/dotnet/desktop/winforms/controls/media/how-to-add-an-event-handler/visual-studio-properties-events-click.png?view=netdesktop-5.0&branch=pr-en-us-1113
Resource dotnet-desktop-guide/net/winforms/media/shared/visual-studio-chevron-button.png https://review.docs.microsoft.com/en-us/dotnet/desktop/winforms/media/shared/visual-studio-chevron-button.png?view=netdesktop-5.0&branch=pr-en-us-1113
Resource dotnet-desktop-guide/net/winforms/media/shared/visual-studio-ellipsis-button.png https://review.docs.microsoft.com/en-us/dotnet/desktop/winforms/media/shared/visual-studio-ellipsis-button.png?view=netdesktop-5.0&branch=pr-en-us-1113
Resource dotnet-desktop-guide/net/winforms/media/shared/visual-studio-events-button.png https://review.docs.microsoft.com/en-us/dotnet/desktop/winforms/media/shared/visual-studio-events-button.png?view=netdesktop-5.0&branch=pr-en-us-1113
Toc dotnet-desktop-guide/net/winforms/toc.yml https://review.docs.microsoft.com/en-us/dotnet/desktop/winforms/toc.json?view=netdesktop-5.0&branch=pr-en-us-1113

@adegeo adegeo marked this pull request as ready for review July 19, 2021 19:07
Copy link

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adegeo looks good to me. Added a few comments.


[!INCLUDE [desktop guide under construction](../../includes/desktop-guide-preview-note.md)]

## Designer

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Make heading more descriptive. Below is an idea, though it may be a bit wordy. Feel free to cut / wordsmith to whatever you thing is appropriate

Suggested change
## Designer
## Handle events in Visual Studio Visual Designer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does it sound now?


01. Right-click on the event and choose **Reset**.

## Programmatic

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comment to "Designer" H2. Make it more descriptive. i.e. "Handle events programmatically", "Handle events at run-time", "Handle events (code-first)"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luisquintanilla How does this sound? I used the same format on the other article too. I'm trying not to be too wordy on the headings because they're wrapping.

Copy link

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. The only item outstanding is VB content showing up for C#.

image

image

@adegeo
Copy link
Contributor Author

adegeo commented Jul 19, 2021

@luisquintanilla Really there isn't anything I can do about it. But I have to call it out. I at least added it to a section named Visual Basic so it's clearer.

@adegeo
Copy link
Contributor Author

adegeo commented Jul 19, 2021

@luisquintanilla thanks a bunch for the good review!

@adegeo adegeo merged commit 5d38c60 into main Jul 19, 2021
@adegeo adegeo deleted the winforms-76 branch July 19, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants