-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add control event articles #1113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adegeo looks good to me. Added a few comments.
dotnet-desktop-guide/net/winforms/controls/how-to-add-an-event-handler.md
Outdated
Show resolved
Hide resolved
|
||
[!INCLUDE [desktop guide under construction](../../includes/desktop-guide-preview-note.md)] | ||
|
||
## Designer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Make heading more descriptive. Below is an idea, though it may be a bit wordy. Feel free to cut / wordsmith to whatever you thing is appropriate
## Designer | |
## Handle events in Visual Studio Visual Designer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does it sound now?
|
||
01. Right-click on the event and choose **Reset**. | ||
|
||
## Programmatic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar comment to "Designer" H2. Make it more descriptive. i.e. "Handle events programmatically", "Handle events at run-time", "Handle events (code-first)"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luisquintanilla How does this sound? I used the same format on the other article too. I'm trying not to be too wordy on the headings because they're wrapping.
dotnet-desktop-guide/net/winforms/controls/how-to-add-an-event-handler.md
Outdated
Show resolved
Hide resolved
dotnet-desktop-guide/net/winforms/controls/how-to-add-a-picture-to-a-control.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luisquintanilla Really there isn't anything I can do about it. But I have to call it out. I at least added it to a section named Visual Basic so it's clearer. |
@luisquintanilla thanks a bunch for the good review! |
Summary
Contributes to #76
@luisquintanilla
Preview Links: