Add locate projects #100
Merged
Add locate projects #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a global solution file that contains all existing projects. This will make it easier to work on shared code across multiple projects. - Add entries in the gitignore file to include all Visual Studio file types.
Add the LocateProjects project, along with its dependencies
Where code has been duplicated, remove the duplicate copy.
As this work continues, I'll bump the lowest version marker up on each PR so we can track any possible regressions.
13 tasks
IEvangelist
requested changes
Jan 10, 2023
- Move the Quest version of GitHubClient into the shared library. Now, all tools will benefit from the Polly resilience. - Comment out, or remove code not used in the projects being ported yet. Admittedly, commenting out some APIs incurs a small amount of short-term technical debt. As I finish porting all the code, the last PR should remove all unused code.
|
Thanks @IEvangelist This is ready for a second look |
IEvangelist
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #99
This may be easier to review commit-by-commit.
In this PR, I created a new global solution that builds all tools in this repository. That makes it easier to find duplicate code.
Next, I added the LocateProjects project and its dependencies into this repo. No functional changes, just a straight move.
Finally, I removed duplicated code where we'd copied some utility code while creating the Quest2GitHub project.
Then, update the version on all affected projects.