Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add locate projects #100

Merged
merged 5 commits into from
Jan 10, 2023
Merged

Add locate projects #100

merged 5 commits into from
Jan 10, 2023

Conversation

BillWagner
Copy link
Member

Contributes to #99

This may be easier to review commit-by-commit.

In this PR, I created a new global solution that builds all tools in this repository. That makes it easier to find duplicate code.
Next, I added the LocateProjects project and its dependencies into this repo. No functional changes, just a straight move.
Finally, I removed duplicated code where we'd copied some utility code while creating the Quest2GitHub project.
Then, update the version on all affected projects.

- Add a global solution file that contains all existing projects. This will make it easier to work on shared code across multiple projects.
- Add entries in the gitignore file to include all Visual Studio file types.
Add the LocateProjects project, along with its dependencies
Where code has been duplicated, remove the duplicate copy.
As this work continues, I'll bump the lowest version marker up on each PR so we can track any possible regressions.
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good thus far, but there are two files that should be reverted. Otherwise, let's :shipit:

DotNet.DocsTools/GitHubCommunications/GitHubClient.cs Outdated Show resolved Hide resolved
- Move the Quest version of GitHubClient into the shared library. Now, all tools will benefit from the Polly resilience.
- Comment out, or remove code not used in the projects being ported yet.

Admittedly, commenting out some APIs incurs a small amount of short-term technical debt. As I finish porting all the code, the last PR should remove all unused code.
@BillWagner
Copy link
Member Author

Thanks @IEvangelist

This is ready for a second look

Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, :shipit: when you're ready.

@BillWagner BillWagner merged commit badd261 into dotnet:main Jan 10, 2023
@BillWagner BillWagner deleted the add-locate-projects branch January 10, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants