Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComboBox Shift+Tab not working then IsEditable is True #11552

Closed
1 task
ghost opened this issue Mar 29, 2019 · 5 comments
Closed
1 task

ComboBox Shift+Tab not working then IsEditable is True #11552

ghost opened this issue Mar 29, 2019 · 5 comments
Labels
doc-bug Problem with the content; needs to be fixed [org][type][category] dotnet-framework/svc Pri2 won't fix Issues that were closed as part of automated backlog grooming wpf/subsvc

Comments

@ghost
Copy link

ghost commented Mar 29, 2019

Issue description

I try to make a custom ComboBox. But i have a problem with the example from this document.
The SHIFT+TAB not working then the IsEditable is True.

Target framework

  • .NET Framework - 4.5.2

edit by @mairaw: added document details


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Mar 29, 2019
@mairaw mairaw added doc-bug Problem with the content; needs to be fixed [org][type][category] P2 and removed ⌚ Not Triaged Not triaged labels Dec 4, 2019
@mairaw
Copy link
Contributor

mairaw commented Dec 9, 2019

Thanks for your feedback @Andro-Marian. @grubioe can you please check this feedback for a WPF article?

@grubioe
Copy link

grubioe commented Dec 10, 2019

@BionicCode
Copy link

BionicCode commented Nov 22, 2020

Solution

It's required to disable the tab stop for the case that the ComboBox is in edit mode (IsEditable="True").
To avoid such situations, it's always recommended to edit a copy of the original control styles by going to the XAML design view and right-click the corresponding control and select "Edit Template | Edit a Copy..." from the context menu.
Alternatively it's possible to use Visual Studio Blend to modify the default style. The styles and templates provided on Microsoft Docs are not always accurate.

To solve the issue you should add a Trigger to the style (which is present in the original style,, when following the above steps to retrieve the control's original style):

<Style x:Key="{x:Type ComboBox}"
       TargetType="{x:Type ComboBox}">

  ...

  <Style.Triggers>
    <Trigger Property="IsEditable" Value="true">
      <Setter Property="IsTabStop" Value="false" />
    </Trigger>
  </Style.Triggers>
</Style>

@rladuca
Copy link
Member

rladuca commented Nov 23, 2020

@fabiant3 @SamBent @ryalanms We were tagged on this a while back, but I don't have any insight into how this bug came about. Tagging you to notify you of this one.

@PRMerger7 PRMerger7 added the Pri2 label Jan 16, 2021
@dotnet-bot
Copy link
Contributor

This issue has been closed as part of the issue backlog grooming process outlined in #22351.

That automated process may have closed some issues that should be addressed. If you think this is one of them, reopen it with a comment explaining why. Tag the @dotnet/docs team for visibility.

@dotnet-bot dotnet-bot added the won't fix Issues that were closed as part of automated backlog grooming label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-bug Problem with the content; needs to be fixed [org][type][category] dotnet-framework/svc Pri2 won't fix Issues that were closed as part of automated backlog grooming wpf/subsvc
Projects
None yet
Development

No branches or pull requests

8 participants