Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashes in the tool name in the "Name" section of tool docs? #29676

Closed
omajid opened this issue May 31, 2022 · 2 comments · Fixed by #29974
Closed

Dashes in the tool name in the "Name" section of tool docs? #29676

omajid opened this issue May 31, 2022 · 2 comments · Fixed by #29974
Assignees
Labels
doc-enhancement Improve the current content [org][type][category] Pri2
Projects

Comments

@omajid
Copy link
Member

omajid commented May 31, 2022

The .NET Core tool docs sometimes include a dash in the command name (dotnet-vstest) and sometimes they dont (dotnet add package). Should they stick to one style?

$ head -13 ./docs/core/tools/dotnet-add-package.md | tail -4
## Name

`dotnet add package` - Adds or updates a package reference in a project file.

$ head -16 ./docs/core/tools/dotnet-vstest.md | tail -4
## Name

`dotnet-vstest` - Runs tests from the specified assemblies.

I am not sure what style this doc is trying to follow, but man pages, which are closely aligned, always use a dash. For example:

$ man git add
...
NAME
       git-add - Add file contents to the index

What should the style in these docs be?

See also dotnet/sdk#25709

cc @mairaw

@mairaw
Copy link
Contributor

mairaw commented May 31, 2022

Adding @baronfel and @tdykstra since it's been a few years since I've worked on those docs.

We did create those docs following similar existing docs like git. There was a point where we did have hyphens in the doc titles for example, but we removed after getting feedback that it was confusing.

I'll let the new owners decide what style we should use and apply it consistently.

@tdykstra tdykstra self-assigned this May 31, 2022
@tdykstra tdykstra added doc-enhancement Improve the current content [org][type][category] Pri2 and removed Pri3 labels May 31, 2022
@baronfel
Copy link
Member

I did a quick regex search across the markdown docs for the CLI tools and only 2 pages use the dash syntax - dotnet-vstest and dotnet-install. The dotnet-install page is for the actual script named dotnet-install(.sh|.ps1) so I'm fine excluding it from the discussion.

I think we should make dotnet-vstest use the space version of the name to bring it into alignment with the others (and to make the HTML-rendered pages remain clear for webpage viewers), and then in the SDK's man page generation scripts apply the necessary _ formatting to mitigate the lint warnings for Debian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-enhancement Improve the current content [org][type][category] Pri2
Projects
No open projects
June 2022
  
Done
Development

Successfully merging a pull request may close this issue.

6 participants