Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct issue with generated code for regex. #40566

Merged
merged 1 commit into from Apr 28, 2024
Merged

Correct issue with generated code for regex. #40566

merged 1 commit into from Apr 28, 2024

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Apr 19, 2024 •
edited

Summary

Correct issue with generated code for regex.

Fixes #40477, tagging @RedFlames and @adamsitnik

Internal previews

馃搫 File 馃敆 Preview link
docs/standard/base-types/regular-expression-source-generators.md .NET regular expression source generators

@dotnet-bot dotnet-bot added this to the April 2024 milestone Apr 19, 2024
tdykstra
tdykstra approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IEvangelist IEvangelist merged commit 305ae28 into dotnet:main Apr 28, 2024
11 checks passed
@adegeo adegeo mentioned this pull request May 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdykstra tdykstra tdykstra approved these changes

@adegeo adegeo Awaiting requested review from adegeo adegeo is a code owner

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
April 2024
Development

Successfully merging this pull request may close these issues.

".NET regular expression source generators" - wrong code snippets in article for .NET 8
3 participants
@IEvangelist @tdykstra @dotnet-bot