Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the need for SG to target netstandard2.0 #40644

Merged
merged 2 commits into from Apr 29, 2024

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Apr 27, 2024

Fixes #40603


Internal previews

馃搫 File 馃敆 Preview link
docs/csharp/roslyn-sdk/source-generators-overview.md Source Generators

@dotnet-bot dotnet-bot added this to the April 2024 milestone Apr 27, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Apr 27, 2024
Co-authored-by: Jacob Marks <19641427+jacobjmarks@users.noreply.github.com>
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @Youssef1313

I'll :shipit: now.

@BillWagner BillWagner merged commit fa21a4b into dotnet:main Apr 29, 2024
8 checks passed
@Youssef1313 Youssef1313 deleted the patch-38 branch April 29, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-csharp/svc roslyn-sdk/subsvc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Generators: Necessity to target netstandard2.0?
5 participants