Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NameItemTemplate sample #7589

Closed
SimpleSamples opened this issue Sep 8, 2018 — with docs.microsoft.com · 6 comments
Closed

NameItemTemplate sample #7589

SimpleSamples opened this issue Sep 8, 2018 — with docs.microsoft.com · 6 comments
Labels
doc-enhancement Improve the current content [org][type][category] dotnet-framework/svc Pri2 waiting-on-feedback Waiting for feedback from SMEs before they can be merged won't fix Issues that were closed as part of automated backlog grooming wpf/subsvc
Milestone

Comments

Copy link
Contributor

I found a NameItemTemplate sample that seems to work here too; see:
https://github.com/Microsoft/WPF-Samples/blob/master/Data%20Binding/MultiBinding/MainWindow.xaml

I added both the line for local:NameConverter and the block for the DataTemplate. I also added the NameConverter class to my project.

Is that an appropriate sample for here?


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@BillWagner BillWagner added triaged doc-enhancement Improve the current content [org][type][category] doc-idea Indicates issues that are suggestions for new topics [org][type][category] and removed ⌚ Not Triaged Not triaged doc-idea Indicates issues that are suggestions for new topics [org][type][category] labels Oct 1, 2018
@BillWagner BillWagner added this to the Backlog milestone Oct 1, 2018
@BillWagner BillWagner added the waiting-on-feedback Waiting for feedback from SMEs before they can be merged label Oct 1, 2018
@rpetrusha
Copy link
Contributor

Thanks, @SimpleSamples, for your feedback; I apologize that it's taken us so long to respond to you. Yes, that is an appropriate sample for the documentation. If you'd like to open a PR, we'd be delighted to review it. The sample code goes in the dotnet/samples repo.

@SimpleSamples
Copy link
Contributor Author

Thank you. I have a working project that I can copy from for the samples. I am not sure how to proceed. I assume you want to add the sample code to this article instead of referring to it. I think that most or all of the changes involve updating the resources sample code and adding the NameConverter class. The following is what I have for the resources.
<Window.Resources> <c:NameList x:Key="NameListData"/> <c:NameConverter x:Key="MyNameConverter"/> <DataTemplate x:Key="NameItemTemplate"> <TextBlock> <TextBlock.Text> <MultiBinding Converter="{StaticResource MyNameConverter}"> <Binding Path="FirstName"/> <Binding Path="LastName"/> </MultiBinding> </TextBlock.Text> </TextBlock> </DataTemplate> </Window.Resources>

Do I update the article the same way I have updated articles or is there something special I should do to link it to here? I don't know how to update code or add code to the dotnet/samples repo. Perhaps that will be obvious when I update the article.

@SimpleSamples
Copy link
Contributor Author

I believe I originally submitted a link to an article and that link got changed to a link to the code in GitHub. The link to GitHub helps but it would help if I could see how the sample code was referred to. I have searched for the article that had the NameItemTemplate sample and related code and I cannot find it.

As for my other questions, I have created Updating Microsoft's documentation in GitHub.

Copy link

Hey , @SimpleSamples, can i get a link to that example?

@SamHobbsOrg
Copy link

Look at my initial post here. Click on the link. Then click to go one level up. I think that is the sample. If not then I will look later.

@dotnet-bot
Copy link
Contributor

This issue has been closed as part of the issue backlog grooming process outlined in #22351.

That automated process may have closed some issues that should be addressed. If you think this is one of them, reopen it with a comment explaining why. Tag the @dotnet/docs team for visibility.

@dotnet-bot dotnet-bot added the won't fix Issues that were closed as part of automated backlog grooming label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-enhancement Improve the current content [org][type][category] dotnet-framework/svc Pri2 waiting-on-feedback Waiting for feedback from SMEs before they can be merged won't fix Issues that were closed as part of automated backlog grooming wpf/subsvc
Projects
None yet
Development

No branches or pull requests

10 participants