Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code example should not use APM #925

Open
svick opened this issue Sep 22, 2018 · 1 comment
Open

Code example should not use APM #925

svick opened this issue Sep 22, 2018 · 1 comment
Labels
area-System.IO dotnet-api/prod Pri2 Indicates issues/PRs that are medium priority untriaged New issue has not been triaged by the area owner

Comments

@svick
Copy link
Contributor

svick commented Sep 22, 2018

The code example for this page uses the APM (as can be seen from it calling EndRead). Since APM is not recommended anymore, I think examples should not use it (unless they have to).

Fixing this would involve changing this page, the larger example in the FileStream constructor and also other pages that use this example, if any.


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@rpetrusha
Copy link

Thanks for pointing out that this example is in need of modernization, @svick. I've added it to our backlog, as well as to the community contributor's project.

@BillWagner BillWagner transferred this issue from dotnet/docs Nov 20, 2018
@dotnet-bot dotnet-bot added untriaged New issue has not been triaged by the area owner Source - Docs.ms and removed rerun-labels labels Nov 20, 2018
@PRMerger10 PRMerger10 added the Pri2 Indicates issues/PRs that are medium priority label Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.IO dotnet-api/prod Pri2 Indicates issues/PRs that are medium priority untriaged New issue has not been triaged by the area owner
Projects
None yet
Development

No branches or pull requests

6 participants