Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default values for XmlReaderSettings #10028

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

omajid
Copy link
Member

@omajid omajid commented Jun 14, 2024

  • Sort the table alphabetically
  • Add missing CloseInput property
  • Fix link to DtdProcessing property: it should point to System.Xml.XmlReaderSettings.DtdProcessing.

- Sort the table alphabetically
- Add missing `CloseInput` property
- Fix link to `DtdProcessing` property: it should point to
  System.Xml.XmlReaderSettings.DtdProcessing.
@omajid omajid requested a review from a team as a code owner June 14, 2024 20:51
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 14, 2024
Copy link

Learn Build status updates of commit e2d2b61:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Xml/XmlReaderSettings.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@omajid
Copy link
Member Author

omajid commented Jun 19, 2024

cc @adegeo

Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked in the framework 4.8 code and it's defaulting to false.

@adegeo adegeo enabled auto-merge (squash) July 11, 2024 16:58
@adegeo
Copy link
Contributor

adegeo commented Jul 11, 2024

@gewarren Hrmmm I don't perms here anymore (or never did, I don't know which lol)

@adegeo adegeo merged commit a76afd3 into dotnet:main Jul 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Xml community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants