Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update InlineArrayAttribute.xml #10036

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Conversation

AaronRobinsonMSFT
Copy link
Member

Add note about behavior of Equals() and GetHashCode() when InlineArrayAttribute is applied to a ValueType.

See dotnet/runtime#103612

Add note about behavior of Equals() and GetHashCode() when InlineArrayAttribute is applied to a ValueType.

This comment was marked as outdated.

This comment was marked as outdated.

@AaronRobinsonMSFT AaronRobinsonMSFT marked this pull request as ready for review June 20, 2024 17:53
@AaronRobinsonMSFT AaronRobinsonMSFT requested a review from a team as a code owner June 20, 2024 17:53
@AaronRobinsonMSFT
Copy link
Member Author

/cc @gewarren @stephentoub

@AaronRobinsonMSFT
Copy link
Member Author

@stephentoub I didn't change the content of the "Tip" on ValueType.Equals(), but did change it to be "Important". Would you prefer stronger language about overridding it by users?

Copy link

Learn Build status updates of commit 74f0911:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Runtime.CompilerServices/InlineArrayAttribute.xml ⚠️Warning View Details
xml/System/ValueType.xml ✅Succeeded View

xml/System.Runtime.CompilerServices/InlineArrayAttribute.xml

  • Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'see' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

xml/System/ValueType.xml Outdated Show resolved Hide resolved
xml/System/ValueType.xml Outdated Show resolved Hide resolved
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@gewarren
Copy link
Contributor

Do we also need to preface these comments with ".NET 9 and later"?

@AaronRobinsonMSFT
Copy link
Member Author

Do we also need to preface these comments with ".NET 9 and later"?

Seems reasonable. I will do that.

Copy link

Learn Build status updates of commit dba4cb0:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Runtime.CompilerServices/InlineArrayAttribute.xml ✅Succeeded View
xml/System/ValueType.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 9054598:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Runtime.CompilerServices/InlineArrayAttribute.xml ✅Succeeded View
xml/System/ValueType.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit d935ac6 into main Jun 20, 2024
3 checks passed
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the AaronRobinsonMSFT-patch-1 branch June 20, 2024 21:04
@stephentoub
Copy link
Member

@stephentoub I didn't change the content of the "Tip" on ValueType.Equals(), but did change it to be "Important". Would you prefer stronger language about overridding it by users?

That's fine, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants