New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revised Type class to better document BindingFlags behavior #2387
Conversation
Closing and reopening to begin new build. |
@steveharter may help reviewing the changes here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments re. the style rule for flag enums but it doesn't cover all of them.
I wasn't able to batch merge your suggestions, @mairaw, so I did them in a separate local commit. Thanks for the suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Revised to document BindingFlags behavior
This PR corrects a number of inaccuracies in the Type documentation:
Fixes #2052
//cc @tarekgh @GrabYourPitchforks