coreclr: Automatic port of triple slash from System.Runtime.Loader #2727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
added
🏁 Release: .NET Core 3.0
bartonjs
approved these changes
Jul 8, 2019
rpetrusha
approved these changes
Jul 9, 2019
There was a problem hiding this comment.
I've made a minor change, but otherwise LGTM, @carlossanlop. I'll merge when the build completes successfully.
rpetrusha
added
verify-build-before-merge
and removed
waiting-on-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found one triple slash comment that could be automatically ported from dotnet/coreclr.
Adding area owners @joperezr @bartonjs to double check that the descriptions are correct. After this PR is checked-in, please proceed to manually document all the APIs that have missing documentation.
Adding @mairaw @rpetrusha for language review.