Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSBuild: remove unresolved refs #4994

Merged
merged 2 commits into from Oct 19, 2020
Merged

Conversation

ghogen
Copy link
Contributor

@ghogen ghogen commented Oct 15, 2020

Summary

Describe your changes here.

Fixes #Issue_Number (if available)

@ghogen ghogen changed the title remove unresolved refs MSBuild: remove unresolved refs Oct 15, 2020
@ghogen
Copy link
Contributor Author

ghogen commented Oct 15, 2020

I didn't resolve the CircularDependencyException reference, because that appears to be a substantive record of an exception that could be thrown, but it's in Microsoft.Build.Backend, which is not published. So, asked @rainersigwald about how to resolve this.

@opbld32
Copy link

opbld32 commented Oct 15, 2020

Docs Build status updates of commit c4444ce:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Build.Evaluation/Project.xml ✅Succeeded View
xml/Microsoft.Build.Evaluation/ProjectCollection.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld32
Copy link

opbld32 commented Oct 19, 2020

Docs Build status updates of commit 78f32f7:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Build.Evaluation/Project.xml ✅Succeeded View
xml/Microsoft.Build.Evaluation/ProjectCollection.xml ✅Succeeded View
xml/Microsoft.Build.Graph/ProjectGraph.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@ghogen
Copy link
Contributor Author

ghogen commented Oct 19, 2020

#sign-off

@ghogen
Copy link
Contributor Author

ghogen commented Oct 19, 2020

@v-alje Can you merge this? I resolved the question about CircularDependencyException, so we're good to go with this change to fix the warnings in the other PR: #4939

@v-alje v-alje merged commit e4d3680 into dotnet:release-msbuild Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants