Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing exception information #636

Merged
merged 1 commit into from Oct 24, 2018
Merged

Added missing exception information #636

merged 1 commit into from Oct 24, 2018

Conversation

rpetrusha
Copy link

Added missing exception information

In reviewing dotnet/samples#377, I noticed that some exception information was missing. This PR:

  • Adds one undocumented exception condition.
  • Adds one undocumented exception.
  • Removes a block of duplicated text.

@rpetrusha rpetrusha self-assigned this Oct 17, 2018
BillWagner
BillWagner approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @rpetrusha

You can :shipit: when ready.

@rpetrusha rpetrusha merged commit d42d6e7 into dotnet:master Oct 24, 2018
@rpetrusha rpetrusha deleted the missing-exceptions branch November 5, 2018 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees

@rpetrusha rpetrusha

Labels
None yet
Projects
None yet
Milestone
Sprint 143 (10/15/2018 - 11/02/2018)
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rpetrusha @BillWagner