Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add case-insensitive note #8064

Merged
merged 3 commits into from May 16, 2022
Merged

add case-insensitive note #8064

merged 3 commits into from May 16, 2022

Conversation

marsen
Copy link
Contributor

@marsen marsen commented May 11, 2022

note that the name of the configuration section is case-insensitive.

Summary

Added this note to provide more information to developers

Fixes #Issue_Number (if available)

note that the name of the configuration section is case-insensitive.
@marsen marsen requested a review from a team as a code owner May 11, 2022 07:32
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@opbld33
Copy link

opbld33 commented May 11, 2022

Docs Build status updates of commit 2cd06f9:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Extensions.Configuration/ConfigurationManager.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that info should rather go in the remarks?

@@ -127,7 +127,7 @@
<Docs>
<param name="key">To be added.</param>
<summary>Gets a configuration subsection with the specified key.</summary>
<returns>The configuration section for the specified key.</returns>
<returns>The configuration section for the specified key, note that the name of the configuration section is case-insensitive. </returns>
<remarks>To be added.</remarks>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<remarks>To be added.</remarks>
<remarks>The name of the configuration section is case-insensitive.</remarks>

marsen and others added 2 commits May 17, 2022 03:32
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld30
Copy link

opbld30 commented May 16, 2022

Docs Build status updates of commit 280f5e8:

⚠️ Validation status: warnings

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld34
Copy link

opbld34 commented May 16, 2022

Docs Build status updates of commit 34643e1:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Extensions.Configuration/ConfigurationManager.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren gewarren merged commit b420625 into dotnet:main May 16, 2022
@gewarren
Copy link
Contributor

Thank you @marsen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants