Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing 7.0 docs for isolated APIs in various namespaces #8230

Merged
merged 9 commits into from
Jul 19, 2022

Conversation

carlossanlop
Copy link
Member

Found a few scattered APIs that were missing some documentation.

Area owners, please review:

  • @dotnet/area-system-text-json
  • @dotnet/area-system-text-regularexpressions
  • @kouvel (for System.Threading)
  • @dotnet/area-system-runtime (for System.Timers)
  • @dotnet/area-extensions-configuration
  • @dotnet/area-system-componentmodel
  • @dotnet/area-system-io (for System.Formats.Tar)

@carlossanlop carlossanlop requested review from a team July 19, 2022 00:34
@carlossanlop carlossanlop self-assigned this Jul 19, 2022
@carlossanlop carlossanlop requested review from a team and kouvel as code owners July 19, 2022 00:34
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Jul 19, 2022
@opbld32

This comment was marked as outdated.

@tarekgh
Copy link
Member

tarekgh commented Jul 19, 2022

Microsoft.Extensions and System.ComponentModel changes LGTM.

Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Text.Json changes look good to me.

@opbld34

This comment was marked as outdated.

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@carlossanlop carlossanlop enabled auto-merge (squash) July 19, 2022 19:33
@opbld34
Copy link

opbld34 commented Jul 19, 2022

Docs Build status updates of commit db75935:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/Microsoft.Extensions.Configuration/ConfigurationDebugViewContext.xml ⚠️Warning View Details
xml/System.Text.RegularExpressions/RegexRunner.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Configuration/ConfigurationManager.xml ✅Succeeded View
xml/ns-System.Formats.Tar.xml ✅Succeeded View
xml/System.ComponentModel.Design.Serialization/MemberRelationship.xml ✅Succeeded View
xml/System.Text.Json.Serialization.Metadata/JsonMetadataServices.xml ✅Succeeded View
xml/System.Text.Json.Serialization/JsonPolymorphicAttribute.xml ✅Succeeded View
xml/System.Threading/PeriodicTimer.xml ✅Succeeded View
xml/System.Timers/Timer.xml ✅Succeeded View

xml/Microsoft.Extensions.Configuration/ConfigurationDebugViewContext.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'IConfigurationProvider'.

xml/System.Text.RegularExpressions/RegexRunner.xml

  • Line 0, Column 0: [Warning: ECMA2Yaml_CrefTypePrefixMissing] Invalid cref format (NotSupportedException) detected in C:\LocalRun\W\wj1h-s\xml\System.Text.RegularExpressions\RegexRunner.xml
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'NotSupportedException'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@carlossanlop carlossanlop merged commit 7cc9d56 into dotnet:main Jul 19, 2022
@carlossanlop carlossanlop deleted the IsolatedMissingDocs branch July 19, 2022 20:49
@gewarren gewarren mentioned this pull request Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants