Remove comment about zero padding HMAC{256,384,512} keys. #8761
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The zero padding is not observed in the
Key
property. It's an implementation detail of how HMAC works. To avoid any confusion, let's just remove this comment. We don't have it for HMACSHA1 or HMACMD5.I initially tried to re-word this to something like If it is less than 64 bytes long, the key is internally zero padded to 64 bytes. However, I'm not sure it makes sense to document the internals of how HMAC works in the
key
parameter documentation. I left the documentation for if the key is too large because we do have observable changes to theKey
property in that case.See dotnet/runtime#80180 for background on why I am suggesting this change.