Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strmreader read2.cs #8958

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jontho-microsoft-com
Copy link

.NET source code clearly shows Read() may not return a fixed number of characters, but only what's currently available on the stream. ReadBlock returns the stated number of characters and only returns fewer if end of stream

Summary

Describe your changes here.

Fixes #Issue_Number (if available)

.NET source code clearly shows Read() may not return a fixed number of characters, but only what's currently available on the stream. ReadBlock returns the stated number of characters and only returns fewer if end of stream
@jontho-microsoft-com jontho-microsoft-com requested a review from a team as a code owner April 12, 2023 22:42
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Apr 12, 2023
@ghost
Copy link

ghost commented Apr 12, 2023

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

.NET source code clearly shows Read() may not return a fixed number of characters, but only what's currently available on the stream. ReadBlock returns the stated number of characters and only returns fewer if end of stream

Summary

Describe your changes here.

Fixes #Issue_Number (if available)

Author: jontho-microsoft-com
Assignees: -
Labels:

area-System.IO, community-contribution

Milestone: -

@jontho-microsoft-com jontho-microsoft-com marked this pull request as draft April 12, 2023 22:51
@learn-build-service-prod
Copy link

Learn Build status updates of commit 5ef0e00:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System.IO/StreamReader/Read/strmreader read2.cs ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution @jontho-microsoft-com !

This PR is a draft, do you want to add something more before merging it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.IO community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants