Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix filter #9515

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Try to fix filter #9515

merged 1 commit into from
Dec 18, 2023

Conversation

gewarren
Copy link
Contributor

Fixes #9511.

@gewarren gewarren requested a review from a team as a code owner December 16, 2023 00:08
@ghost ghost assigned gewarren Dec 16, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Dec 16, 2023
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link

Learn Build status updates of commit 54e918c:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/Microsoft.Extensions.AsyncState/IAsyncLocalContext`1.xml ⚠️Warning Details
xml/Microsoft.Extensions.DependencyInjection/AsyncStateExtensions.xml ⚠️Warning View Details
xml/Microsoft.Extensions.DiagnosticAdapter.Internal/InvalidProxyOperationException.xml ⚠️Warning Details
xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyAssembly.xml ⚠️Warning Details
xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyBase.xml ⚠️Warning Details
xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyBase`1.xml ⚠️Warning Details
xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyEnumerable`2.xml ⚠️Warning Details
xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyEnumerable`2+ProxyEnumerator.xml ⚠️Warning Details
xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyFactory.xml ⚠️Warning Details
xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyList`2.xml ⚠️Warning Details
xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyMethodEmitter.xml ⚠️Warning Details
xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyTypeCache.xml ⚠️Warning Details
xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyTypeCacheResult.xml ⚠️Warning Details
xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyTypeEmitter.xml ⚠️Warning Details
xml/Microsoft.Extensions.Localization.Internal/AssemblyResourceStringProvider.xml ⚠️Warning Details
xml/Microsoft.Extensions.Localization.Internal/AssemblyWrapper.xml ⚠️Warning Details
xml/Microsoft.Extensions.Localization.Internal/IResourceStringProvider.xml ⚠️Warning Details
xml/Microsoft.Extensions.Localization.Internal/ResourceManagerStringProvider.xml ⚠️Warning Details
xml/Microsoft.Extensions.Logging/LoggerMessageHelper.xml ⚠️Warning Details
xml/Microsoft.Extensions.Logging/LoggerMessageState.xml ⚠️Warning Details
xml/Microsoft.Extensions.Logging/LoggerMessageState+ClassifiedTag.xml ⚠️Warning Details
xml/ns-Microsoft.Extensions.DiagnosticAdapter.Internal.xml ⚠️Warning Details
xml/ns-Microsoft.Extensions.Localization.Internal.xml ⚠️Warning Details
xml/ns-Polly.xml ⚠️Warning Details
xml/Polly/HttpRequestMessageExtensions.xml ⚠️Warning Details

This comment lists only the first 25 files in the pull request.

xml/Microsoft.Extensions.AsyncState/IAsyncLocalContext`1.xml

  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.AsyncState/IAsyncLocalContext`1.xml with URL /dotnet/api/microsoft.extensions.asyncstate.iasynclocalcontext-1 was deleted without redirection. To avoid broken links, add a redirection.

xml/Microsoft.Extensions.DependencyInjection/AsyncStateExtensions.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.AsyncState.IAsyncLocalContext`1'.

xml/Microsoft.Extensions.DiagnosticAdapter.Internal/InvalidProxyOperationException.xml

  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.DiagnosticAdapter.Internal/InvalidProxyOperationException.xml with URL /dotnet/api/microsoft.extensions.diagnosticadapter.internal.invalidproxyoperationexception was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.DiagnosticAdapter.Internal/InvalidProxyOperationException.xml with URL /dotnet/api/microsoft.extensions.diagnosticadapter.internal.invalidproxyoperationexception.-ctor was deleted without redirection. To avoid broken links, add a redirection.

xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyAssembly.xml

  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyAssembly.xml with URL /dotnet/api/microsoft.extensions.diagnosticadapter.internal.proxyassembly was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyAssembly.xml with URL /dotnet/api/microsoft.extensions.diagnosticadapter.internal.proxyassembly.definetype was deleted without redirection. To avoid broken links, add a redirection.

xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyBase.xml

  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyBase.xml with URL /dotnet/api/microsoft.extensions.diagnosticadapter.internal.proxybase was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyBase.xml with URL /dotnet/api/microsoft.extensions.diagnosticadapter.internal.proxybase.-ctor was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyBase.xml with URL /dotnet/api/microsoft.extensions.diagnosticadapter.internal.proxybase.underlyinginstanceasobject was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyBase.xml with URL /dotnet/api/microsoft.extensions.diagnosticadapter.internal.proxybase.upwrap was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyBase.xml with URL /dotnet/api/microsoft.extensions.diagnosticadapter.internal.proxybase.wrappedtype was deleted without redirection. To avoid broken links, add a redirection.

xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyBase`1.xml

  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyBase`1.xml with URL /dotnet/api/microsoft.extensions.diagnosticadapter.internal.proxybase-1 was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyBase`1.xml with URL /dotnet/api/microsoft.extensions.diagnosticadapter.internal.proxybase-1.-ctor was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyBase`1.xml with URL /dotnet/api/microsoft.extensions.diagnosticadapter.internal.proxybase-1.instance was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyBase`1.xml with URL /dotnet/api/microsoft.extensions.diagnosticadapter.internal.proxybase-1.underlyinginstance was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyBase`1.xml with URL /dotnet/api/microsoft.extensions.diagnosticadapter.internal.proxybase-1.underlyinginstanceasobject was deleted without redirection. To avoid broken links, add a redirection.

xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyEnumerable`2.xml

  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyEnumerable`2.xml with URL /dotnet/api/microsoft.extensions.diagnosticadapter.internal.proxyenumerable-2 was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyEnumerable`2.xml with URL /dotnet/api/microsoft.extensions.diagnosticadapter.internal.proxyenumerable-2.-ctor was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyEnumerable`2.xml with URL /dotnet/api/microsoft.extensions.diagnosticadapter.internal.proxyenumerable-2.getenumerator was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyEnumerable`2.xml with URL /dotnet/api/microsoft.extensions.diagnosticadapter.internal.proxyenumerable-2.system-collections-ienumerable-getenumerator was deleted without redirection. To avoid broken links, add a redirection.

xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyEnumerable`2+ProxyEnumerator.xml

  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyEnumerable`2+ProxyEnumerator.xml with URL /dotnet/api/microsoft.extensions.diagnosticadapter.internal.proxyenumerable-2.proxyenumerator was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyEnumerable`2+ProxyEnumerator.xml with URL /dotnet/api/microsoft.extensions.diagnosticadapter.internal.proxyenumerable-2.proxyenumerator.-ctor was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyEnumerable`2+ProxyEnumerator.xml with URL /dotnet/api/microsoft.extensions.diagnosticadapter.internal.proxyenumerable-2.proxyenumerator.current was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyEnumerable`2+ProxyEnumerator.xml with URL /dotnet/api/microsoft.extensions.diagnosticadapter.internal.proxyenumerable-2.proxyenumerator.dispose was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyEnumerable`2+ProxyEnumerator.xml with URL /dotnet/api/microsoft.extensions.diagnosticadapter.internal.proxyenumerable-2.proxyenumerator.movenext was deleted without redirection. To avoid broken links, add a redirection.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gewarren
Copy link
Contributor Author

Looks like this fixes the issue. I think the problem was that there were two separate <apiFilter> nodes.

@gewarren gewarren enabled auto-merge (squash) December 16, 2023 03:43
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gewarren

This looks right, Let's give it a try.

@gewarren gewarren merged commit 2cc0a57 into dotnet:main Dec 18, 2023
3 checks passed
@gewarren gewarren deleted the filter2 branch December 18, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix filter
2 participants