upgrade llvm from 3.9 to 9 #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janvorli
reviewed
Apr 20, 2022
| @@ -56,6 +56,7 @@ RUN apt-get update \ | |||
| && apt-get install -y \ | |||
| autoconf \ | |||
| automake \ | |||
| curl \ | |||
There was a problem hiding this comment.
I think we should keep building the curl from sources. There was a reason for that, I think it was to get libcurl built with the right APIs.
There was a problem hiding this comment.
in the very old days, we used curl directly in HttpClient and it did matter what SSL backend was used. I don't think this is the case any more.
That change is 4 years old touching libcurl-openssl1.0-dev as well.
jkotas
reviewed
Apr 21, 2022
jkotas
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrade llvm to avoid coreclr crashes.
related to dotnet/runtime#66970
curl is already on 7.45.0 so I removed the custom build and added distro package