Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme generation issue #5561

Closed
mthalman opened this issue Jun 13, 2024 · 1 comment · Fixed by dotnet/docker-tools#1337
Closed

Readme generation issue #5561

mthalman opened this issue Jun 13, 2024 · 1 comment · Fixed by dotnet/docker-tools#1337
Labels
area-infrastructure

Comments

@mthalman
Copy link
Member

The PreBuildValidation job runs tests to ensure the Dockerfiles and Readmes are in sync with the templates. This runs the generation logic. For readmes, this is failing when running the rendering tool.

Example build (internal link)

ICM link (internal link)
This was referenced Jun 13, 2024
Merged
Closed
@lbussell
Copy link
Contributor

[Triage] The rendering tool will no longer be supported. We should take this opportunity to remove our dependency on the rendering tool.

@mthalman mthalman changed the title PreBuildValidation job failing due to readme generation issue Readme generation issue Jun 13, 2024
@mthalman mthalman mentioned this issue Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-infrastructure
Projects
.NET Docker
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace rendering tool w/ custom implementation mthalman/docker-tools
2 participants
@mthalman @lbussell