Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The type of "MaxConnections" is error #4328

Merged
merged 1 commit into from
Apr 28, 2023
Merged

The type of "MaxConnections" is error #4328

merged 1 commit into from
Apr 28, 2023

Conversation

wuyuansushen
Copy link
Contributor

Base on the official json schema,
"MaxConnections" has been changed the type from string to int.

Json schema code block:

          "type": [
            "integer",
            "null"
          ],
          "description": "In 'Listen' mode, the maximum amount of connections to accept.",
          "format": "int32"
        },

@wuyuansushen
The type of "MaxConnections" is error
866eb30 
"MaxConnections" has been changed the type from string to int
@wuyuansushen wuyuansushen requested a review from a team as a code owner April 28, 2023 12:49
@ghost ghost added the needs-review label Apr 28, 2023
@ghost ghost removed the needs-review label Apr 28, 2023
@jander-msft jander-msft merged commit 295b57b into dotnet:main Apr 28, 2023
5 checks passed
@wuyuansushen wuyuansushen deleted the patch-1 branch April 29, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jander-msft jander-msft jander-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wuyuansushen @jander-msft